On Thu, Oct 26, 2023 at 02:03:35PM +0530, Raag Jadav wrote: > Now that we have a standard ACPI helper, we can use acpi_dev_uid_match() > for matching _UID as per the original logic before commit 2a036e489eb1 > ("ACPI: LPSS: Refactor _UID handling to use acpi_dev_uid_to_integer()"), > instead of treating it as an integer. > > Signed-off-by: Raag Jadav <raag.jadav@xxxxxxxxx> > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> The change still looks good to me, however I wonder if we could maybe improve acpi_dev_uid_match() to support both data types possible for _UID? This of course is separate patch (unless there are objections). There is the _Generic() thing and I think that can be used to make acpi_dev_uid_match() which takes either u64 (or maybe even unsigned int) or const char * and based on that picks the correct implementation. Not sure if that's possible, did not check but it would allow us to use one function everywhere instead of acpi_dev_uid_to_integer() and acpi_dev_uid_match().