On Sat, Sep 9, 2023 at 5:18 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > On the Peaq C1010 2-in-1 INT33FC:00 pin 3 is connected to > a "dolby" button. At the ACPI level an _AEI event-handler > is connected which sets an ACPI variable to 1 on both > edges. This variable can be polled + cleared to 0 using WMI. > > Since the variable is set on both edges the WMI interface is pretty > useless even when polling. So instead of writing a custom WMI > driver for this the x86-android-tablets code instantiates > a gpio-keys platform device for the "dolby" button. > > Add an ignore_interrupt quirk for INT33FC:00 pin 3 on the Peaq C1010, > so that it is not seen as busy when the gpio-keys driver requests it. > > Note this replaces a hack in x86-android-tablets where it would > call acpi_gpiochip_free_interrupts() on the INT33FC:00 GPIO > controller. acpi_gpiochip_free_interrupts() is considered private > (internal) gpiolib API so x86-android-tablets should stop using it. Yeah, OEMs often don't know what they are doing in firmwares... Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko
