Re: [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 21, 2023 at 03:18:11PM +0200, Cezary Rojewski wrote:
> On 2023-07-21 2:55 PM, Andy Shevchenko wrote:
> > On Fri, Jul 21, 2023 at 02:44:42PM +0200, Cezary Rojewski wrote:
> > > On 2023-07-21 12:48 PM, Andy Shevchenko wrote:
> > > > On Fri, Jul 21, 2023 at 11:47:20AM +0200, Cezary Rojewski wrote:

...

> > > > > @@ -594,6 +594,9 @@ config ACPI_PRMT
> > > > 
> > > > > +config ACPI_NHLT
> > > > 
> > > > Wouldn't be better to squeeze it to the most ordered piece of the file, so
> > > > the list of the table support code files will be kinda ordered?
> > > 
> > > I may be wrong about this, but it seems that the driver/acpi/Kconfig file
> > > does not list tables supported in any kind of ordered fashion. I'd refrain
> > > from reordering the Kconfig in this very patch and rather have such job done
> > > in a separate series instead.
> > 
> > Yes, but my point to make this job easier to whoever will do it.
> 
> Hmm.. I see that the most occurrences of word "Table" is around
> ACPI_SPCR_TABLE/_FPDT/LPIT area. Should I put it after ACPI_LPIT perhaps?

Works for me!
As I wrote "most ordered place" and "kinda ordered" above.

> > > > Otherwise looks good to me, FWIW,
> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux