Re: [PATCH v3 2/4] ACPI: NHLT: Introduce acpi_gbl_nhlt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-07-21 12:48 PM, Andy Shevchenko wrote:
On Fri, Jul 21, 2023 at 11:47:20AM +0200, Cezary Rojewski wrote:
While there is no strict limit to amount of NHLT tables present, usually
just the first one is utilized. To simplify implementation of sound
drivers, provide publicly accessible pointer. Accessing it after calling
acpi_nhlt_get_gbl_table() yields the first NHLT table met during the
scan.

...

@@ -594,6 +594,9 @@ config ACPI_PRMT

+config ACPI_NHLT

Wouldn't be better to squeeze it to the most ordered piece of the file, so
the list of the table support code files will be kinda ordered?

I may be wrong about this, but it seems that the driver/acpi/Kconfig file does not list tables supported in any kind of ordered fashion. I'd refrain from reordering the Kconfig in this very patch and rather have such job done in a separate series instead.

Otherwise looks good to me, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux