On Mon, Jun 5, 2023 at 7:26 PM Luck, Tony <tony.luck@xxxxxxxxx> wrote: > > > > Since 315bada690e0 ("EDAC: Check for GHES preference in the > > > chipset-specific EDAC drivers"), vendor specific EDAC driver will not > > > probe correctly when CONFIG_ACPI_APEI_GHES is enabled but no GHES device > > > is present. Make ghes_get_devices() return NULL when the GHES device > > > list is empty to fix the problem. > > > > > > Fixes: 9057a3f7ac36 ("EDAC/ghes: Prepare to make ghes_edac a proper module") > > > Signed-off-by: Li Yang <leoyang.li@xxxxxxx> > > > Cc: Jia He <justin.he@xxxxxxx> > > > > Boris, Tony, any comments? > > All of the callers are expecting NULL for a failure, not an empty list. So this looks OK to me. > > Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx> Applied as 6.5 material, thanks!