Hi Sakari, On Tue, May 23, 2023 at 1:43 PM Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > Hi Rafael, > > On Tue, May 23, 2023 at 01:21:12PM +0200, Rafael J. Wysocki wrote: > > On Mon, May 22, 2023 at 10:35 PM Sakari Ailus > > <sakari.ailus@xxxxxxxxxxxxxxx> wrote: > > > On Mon, May 22, 2023 at 06:38:37PM +0200, Rafael J. Wysocki wrote: > > > > On Mon, May 22, 2023 at 6:28 PM Sakari Ailus > > > > <sakari.ailus@xxxxxxxxxxxxxxx> wrote: [cut] > > > > > > > > Also I'm kind of wondering about the "reference with arguments" part > > > > which seems to work differently depending on whether the reference is > > > > represented by a string or by a reference object. > > > > > > Yes. With (device) reference objects, it is possible currently to refer to > > > subnodes with the _DSD data extension child names of those nodes. This is > > > not done with string references as 1) any node can already be referenced so > > > there's no need to and 2) as node references are strings already, it's not > > > possible to distinguish node string references from _DSD data node names. > > > E.g. > > > > > > "\\_SB.I2C0.LED0", "LED1" > > > > > > ^ ACPI object name or _DSD data node name? > > > > > > > Has this behavior been documented anywhere? Or is there any > > expectation to see anything like this shipping in production platform > > firmware? > > Good question. Support for this was added by commit 4eb0c3bf5ee52f . AFAIR > it was intended to use this in DisCo for Imaging but after review (in a > rather liberal sense of the term) it was decided to use string-only > references, as in this patch. It looks like this is sort of a placeholder then. > I'm not aware of anyone needing this. They've been there for about five > years but I'd guess someone would complain if it stops working for them. It is also quite straightforward to restore if need be. > > > > If any of the above isn't the case, I would be inclined to simply > > remove this special case and make both the "object reference" and > > "string" cases work in the same way and if someone needs to refer to a > > data node, they will just need to use a string (in which case it will > > be the only option). > > Works for me. OK, I'll make this change then.
