On Fri, Mar 24, 2023 at 05:04:25PM +0000, Russell King (Oracle) wrote:
> On Fri, Mar 24, 2023 at 04:49:32PM +0200, Heikki Krogerus wrote:
> > Hi Russell,
> >
> > On Wed, Mar 22, 2023 at 12:00:21PM +0000, Russell King (Oracle) wrote:
> > > +static struct fwnode_handle *mv88e6xxx_create_fixed_swnode(struct fwnode_handle *parent,
> > > + int speed,
> > > + int duplex)
> > > +{
> > > + struct property_entry fixed_link_props[3] = { };
> > > +
> > > + fixed_link_props[0] = PROPERTY_ENTRY_U32("speed", speed);
> > > + if (duplex == DUPLEX_FULL)
> > > + fixed_link_props[1] = PROPERTY_ENTRY_BOOL("full-duplex");
> > > +
> > > + return fwnode_create_named_software_node(fixed_link_props, parent,
> > > + "fixed-link");
> > > +}
> > > +
> > > +static struct fwnode_handle *mv88e6xxx_create_port_swnode(phy_interface_t mode,
> > > + int speed,
> > > + int duplex)
> > > +{
> > > + struct property_entry port_props[2] = {};
> > > + struct fwnode_handle *fixed_link_fwnode;
> > > + struct fwnode_handle *new_port_fwnode;
> > > +
> > > + port_props[0] = PROPERTY_ENTRY_STRING("phy-mode", phy_modes(mode));
> > > + new_port_fwnode = fwnode_create_software_node(port_props, NULL);
> > > + if (IS_ERR(new_port_fwnode))
> > > + return new_port_fwnode;
> > > +
> > > + fixed_link_fwnode = mv88e6xxx_create_fixed_swnode(new_port_fwnode,
> > > + speed, duplex);
> > > + if (IS_ERR(fixed_link_fwnode)) {
> > > + fwnode_remove_software_node(new_port_fwnode);
> > > + return fixed_link_fwnode;
> > > + }
> > > +
> > > + return new_port_fwnode;
> > > +}
> >
> > That new fwnode_create_named_software_node() function looks like a
> > conflict waiting to happen - if a driver adds a node to the root level
> > (does not have to be root level), all the tests will pass because
> > there is only a single device, but when a user later tries the driver
> > with two devices, it fails, because the node already exist. But you
> > don't need that function at all.
>
> I think you're totally failing to explain how this can fail.
>
> Let me reiterate what thestructure of the swnodes here is:
>
> root
> `- node%d (%d allocated by root IDA)
> +- phy-mode property
> `- fixed-link
> +- speed property
> `- optional full-duplex property
>
> If we have two different devices creating these nodes, then at the
> root level, they will end up having different root names. The
> "fixed-link" is a child of this node.
Ah, sorry, the problem is not with this patch, or your use case. The
problem is with the PATCH 1/7 of this series where you introduce that
new function fwnode_create_named_software_node() which will not be
tied to your use case only. In this patch you just use that function.
I should have been more clear on that.
I really just wanted to show how you can create those nodes by using
the API designed for the statically described software nodes. So you
don't need that new function. Please check that proposal from my
original reply.
If the potential conflict that the new function creates is still not
clear, then - firstly, you have to remember that that API is not only
for your drivers, it's generic API! - the problem comes from the fact
that there simply is nothing preventing it from being used to place
the new nodes always at the same level. So for example using NULL as
the parent:
fwnode = fwnode_create_named_software_node(props,
NULL, /* NOTE */
"same_name");
thanks,
--
heikki
