On Thu, Feb 16, 2023 at 06:44:58PM +0000, Asmaa Mnebhi wrote: > > > +config PINCTRL_MLXBF > > > + tristate "NVIDIA BlueField-3 SoC Pinctrl driver" > > > + depends on (MELLANOX_PLATFORM && ARM64 && ACPI) > > > > This is wrong. > > Please make sure you cover more testing. > > Also, do you really need an ACPI dependency? > > > > Could you please provide more details on why this is wrong? All our > > upstreamed drivers use the same "depends on" Our pinctrl driver only > > applies to Mellanox platforms, ARM64 and use ACPI tables. > > This is wrong because it narrows down testing coverage. > > Besides that you need to define functional and build dependencies separately. > > ACPI probably is not what you are using in the driver. I do not believe you > have at all dependency on it. > > Noted, I will define function and build dependencies separately. > We have our own custom UEFI for BlueField SoCs so ACPI tables are our only > options (for users/customer etc... as well) I understand that, but I'm pretty sure that driver can be compiled with ACPI=n which is good for testing coverage. -- With Best Regards, Andy Shevchenko
