> +config PINCTRL_MLXBF > + tristate "NVIDIA BlueField-3 SoC Pinctrl driver" > + depends on (MELLANOX_PLATFORM && ARM64 && ACPI) This is wrong. Please make sure you cover more testing. Also, do you really need an ACPI dependency? Could you please provide more details on why this is wrong? All our upstreamed drivers use the same "depends on" Our pinctrl driver only applies to Mellanox platforms, ARM64 and use ACPI tables.