Re: [PATCH 2/2] asus-laptop add kill switch support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thomas Renninger wrote :
Hi,

On Thu, 2008-02-07 at 19:06 +0100, Fabien Crespel wrote:
Basically:
- there is now a killswitch file in /sys/devices/platform/asus-laptop/ to report the KS status (read from HWRS)
Not sure, but:
Shouldn't this one register against a general kill-switch interface?
E.g. include/linux/rfkill.h
instead of starting an own interface...

   Thomas
Hello,

after looking at the rfkill interface, it doesn't seem to have the same purpose here : rfkill seems to be here to allow toggling radio frequency of devices in response to a key or another *software* generated event, while the "killswitch" sysfs file in my patch simply provides a way to read whether the *hardware* kill switch is ON (and not write or toggle anything, since it's completely out of software control).

My intention when adding this interface was to allow userspace tools like Lapsus to know when WLAN/Bluetooth are completely *disabled* (and not simply "off"). I don't think the rfkill interface provides a way to know that, or I missed it..? if it doesn't, wouldn't it be interesting to add it?

The rfkill interface seems interesting to support the Fn+F2 key though (WLAN/Bluetooth toggle), since currently it doesn't work on all models.

- Fabien.

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux