Re: [PATCH 5/5] ACPI: add DMI to enable OSI(Linux) on ThinkPad T61

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 19 Feb 2008, Thomas Renninger wrote:
> > Looks quite a bad idea IMO.  2.6.24 means what?  SuSE's?  Mainline's?
> > Debian's?  At what patch level?  With which user patches tacked on top?  And
> > at what level of userspace support (X.org can make a LOT of difference
> > here)?
> 
> So you think on next Lenovo pre-load we should compile a "SLED10 SP2"

Huh?!  No, I don't.  I would walk away in disgust if we did it.  OSI(SLED10
SP2) would be even worse than OSI(Linux) plus a OS<whatever>(2.6.24), I
think I can safely assume that we *all* agree on THAT one.

> into our kernel and let Lenovo BIOS fixups use it? E.g. we could use the
> default BCM/BQC/BCL brightness interface easily then, just a small

AFAIK, there is no problem with the *ACPI* brightness firmware on ThinkPads.
At all.  Its only quirk is that you want to call _BCL at least once at
driver load.

Anyway, the whole backlight brightness stink is our (as in Linux kernel
people, userspace people, distro people) doing.  The laptop vendors, for
once, had nothing to do with it. Also, for once, the ACPI 3.0 specification
(when correctly implemented in the AML *and* ACPI OSI) does give us all we
need to have it work properly in any way we see fit.

Since the brightness issues have *nothing* to do with OSI(anything), let's
leave it for another thread.

> Please let us not end up with hacks like ???"SLED10 SP2", "FEISTY" or
> whatever weirdness and this will come if we ignore osi=linux or do not
> provide something else.
> We should make up something more robust and more Linux kernel
> appropriate and propagate it to the vendors.

We all agree on that, Thomas.

I am actually arguing for something *even* more fine-grained than a kernel
version, but at the same time completely independent of kernel versions, so
that if we backport something, or our userspace improves, we can stop (or
start) advertising it through OSI() without messing with anything else.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux