On Fri, 2008-02-15 at 21:21 -0200, Glauber Costa wrote: > Len Brown wrote: > > I.e. this printk will be present in a production shipping distro kernel > > even if you move to to ACPI_DEBUG_PRINT from printk. > Yes, but you can still disable it. And if you do, all the messages will > vanish, but this will stay. > > > The only variable is the default verbosity level. > > > > Thomas, what verbosity level do you use? > in this patch, I used the same verbosity level as the EJECT request. So > if it is not okay for SuSe, I suggest changing all the others too. That should be ok, thanks for the heads up. It is 0x7: ACPI_LV_ERROR 0x00000001 [*] ACPI_LV_WARN 0x00000002 [*] ACPI_LV_INIT 0x00000004 [*] ACPI_LV_DEBUG_OBJECT 0x00000008 [ ] ACPI_LV_INFO 0x00000010 [ ] ACPI_LV_INIT_NAMES 0x00000020 [ ] All above INIT (already DEBUG_OBJECT) produces unwanted messages and is nothing for default. I remember that default for mainline included DEBUG_OBJECT a while ago, but if I haven't overseen something that should have changed: include/acpi/acoutput.h:#define ACPI_DEBUG_DEFAULT (ACPI_LV_INIT | ACPI_LV_WARN | ACPI_LV_ERROR) drivers/acpi/utilities/utglobal.c:u32 acpi_dbg_level = ACPI_DEBUG_DEFAULT; and everything is fine. Thanks, Thomas > > > thanks, > > -Len > > > > On Friday 15 February 2008 16:28, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > >> The patch titled > >> acpi: use ACPI_DEBUG_PRINT instead of printk > >> has been added to the -mm tree. Its filename is > >> acpi-use-acpi_debug_print-instead-of-printk.patch > >> > >> Before you just go and hit "reply", please: > >> a) Consider who else should be cc'ed > >> b) Prefer to cc a suitable mailing list as well > >> c) Ideally: find the original patch on the mailing list and do a > >> reply-to-all to that, adding suitable additional cc's > >> > >> *** Remember to use Documentation/SubmitChecklist when testing your code *** > >> > >> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find > >> out what to do about this > >> > >> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ > >> > >> ------------------------------------------------------ > >> Subject: acpi: use ACPI_DEBUG_PRINT instead of printk > >> From: Glauber Costa <gcosta@xxxxxxxxxx> > >> > >> For consistency, use ACPI_DEBUG_PRINT instead of printk in > >> acpi_processor_hotplug_notify() for BUS_CHECK and DEVICE_CHECK events > >> > >> Signed-off-by: Glauber Costa <gcosta@xxxxxxxxxx> > >> Cc: Len Brown <lenb@xxxxxxxxxx> > >> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > >> --- > >> > >> drivers/acpi/processor_core.c | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-) > >> > >> diff -puN drivers/acpi/processor_core.c~acpi-use-acpi_debug_print-instead-of-printk drivers/acpi/processor_core.c > >> --- a/drivers/acpi/processor_core.c~acpi-use-acpi_debug_print-instead-of-printk > >> +++ a/drivers/acpi/processor_core.c > >> @@ -890,9 +890,10 @@ acpi_processor_hotplug_notify(acpi_handl > >> switch (event) { > >> case ACPI_NOTIFY_BUS_CHECK: > >> case ACPI_NOTIFY_DEVICE_CHECK: > >> - printk("Processor driver received %s event\n", > >> + ACPI_DEBUG_PRINT((ACPI_DB_INFO, > >> + "Processor driver received %s event\n", > >> (event == ACPI_NOTIFY_BUS_CHECK) ? > >> - "ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK"); > >> + "ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK")); > >> > >> if (!is_processor_present(handle)) > >> break; > >> _ > >> > >> Patches currently in -mm which might be from gcosta@xxxxxxxxxx are > >> > >> remove-is_processor_present-prototype.patch > >> acpi-use-acpi_debug_print-instead-of-printk.patch > >> git-kvm.patch > >> > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
