Since SuSE ships with CONFIG_ACPI_DEBUG=y, the line between printk and ACPI_DEBUG_PRINT is less clear. I.e. this printk will be present in a production shipping distro kernel even if you move to to ACPI_DEBUG_PRINT from printk. The only variable is the default verbosity level. Thomas, what verbosity level do you use? thanks, -Len On Friday 15 February 2008 16:28, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > The patch titled > acpi: use ACPI_DEBUG_PRINT instead of printk > has been added to the -mm tree. Its filename is > acpi-use-acpi_debug_print-instead-of-printk.patch > > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > > *** Remember to use Documentation/SubmitChecklist when testing your code *** > > See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find > out what to do about this > > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ > > ------------------------------------------------------ > Subject: acpi: use ACPI_DEBUG_PRINT instead of printk > From: Glauber Costa <gcosta@xxxxxxxxxx> > > For consistency, use ACPI_DEBUG_PRINT instead of printk in > acpi_processor_hotplug_notify() for BUS_CHECK and DEVICE_CHECK events > > Signed-off-by: Glauber Costa <gcosta@xxxxxxxxxx> > Cc: Len Brown <lenb@xxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > drivers/acpi/processor_core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff -puN drivers/acpi/processor_core.c~acpi-use-acpi_debug_print-instead-of-printk drivers/acpi/processor_core.c > --- a/drivers/acpi/processor_core.c~acpi-use-acpi_debug_print-instead-of-printk > +++ a/drivers/acpi/processor_core.c > @@ -890,9 +890,10 @@ acpi_processor_hotplug_notify(acpi_handl > switch (event) { > case ACPI_NOTIFY_BUS_CHECK: > case ACPI_NOTIFY_DEVICE_CHECK: > - printk("Processor driver received %s event\n", > + ACPI_DEBUG_PRINT((ACPI_DB_INFO, > + "Processor driver received %s event\n", > (event == ACPI_NOTIFY_BUS_CHECK) ? > - "ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK"); > + "ACPI_NOTIFY_BUS_CHECK" : "ACPI_NOTIFY_DEVICE_CHECK")); > > if (!is_processor_present(handle)) > break; > _ > > Patches currently in -mm which might be from gcosta@xxxxxxxxxx are > > remove-is_processor_present-prototype.patch > acpi-use-acpi_debug_print-instead-of-printk.patch > git-kvm.patch > - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
