On Wed, 2023-01-18 at 11:01 -0800, srinivas pandruvada wrote: > On Wed, 2023-01-18 at 13:48 +0000, Zhang, Rui wrote: > > On Wed, 2023-01-18 at 10:53 +0100, Daniel Lezcano wrote: > > > Hi, > > > > > > On 13/01/2023 19:02, Daniel Lezcano wrote: > > > > Recently sent as a RFC, the thermal ACPI for generic trip > > > > points > > > > is > > > > a set of > > > > functions to fill the generic trip points structure which will > > > > become the > > > > standard structure for the thermal framework and its users. > > > > > > > > Different Intel drivers and the ACPI thermal driver are using > > > > the > > > > ACPI tables to > > > > get the thermal zone information. As those are getting the same > > > > information, > > > > providing this set of ACPI function with the generic trip > > > > points > > > > will > > > > consolidate the code. > > > > > > > > Also, the Intel PCH and the Intel 34xx drivers are converted to > > > > use > > > > the generic > > > > trip points relying on the ACPI generic trip point parsing > > > > functions. > > > > > > > > These changes have been tested on a Thinkpad Lenovo x280 with > > > > the > > > > PCH and > > > > INT34xx drivers. No regression have been observed, the trip > > > > points > > > > remain the > > > > same for what is described on this system. > > > > > > Are we ok with this series ? > > > > > > Sorry for insisting but I would like to go forward with the > > > generic > > > thermal trip work. There are more patches pending depending on > > > this > > > series. > > > > The whole series looks good to me. > > > > Reviwed-by: Zhang Rui <rui.zhang@xxxxxxxxx> > > > > But we'd better wait for the thermald test result from Srinvias. > > A quick test show that things still work with thermald and these > changes. But I have a question. In some devices trip point temperature is not static. When hardware changes, we get notification. For example INT3403_PERF_TRIP_POINT_CHANGED for INT3403 drivers. Currently get_trip can get the latest changed value. But if we preregister, we need some mechanism to update them. Thanks, Srinivas > Thanks, > Srinivas > > > > > thanks, > > rui > > > > > > Thanks > > > -- Daniel > > > > > > > Changelog: > > > > - V5: > > > > - Fixed GTSH unit conversion, deciK -> milli C > > > > > > > > - V4: > > > > - Fixed Kconfig option dependency, select THERMAL_ACPI if > > > > ACPI > > > > is set > > > > only for the PCH driver > > > > > > > > - V3: > > > > - Took into account Rafael's comments > > > > - Used a silence option THERMAL_ACPI in order to stay > > > > consistent > > > > with THERMAL_OF. It is up to the API user to select the > > > > option. > > > > > > > > - V2: > > > > - Fix the thermal ACPI patch where the thermal_acpi.c was > > > > not > > > > included in > > > > the series > > > > - Provide a couple of users of this API which could have > > > > been > > > > tested on a > > > > real system > > > > > > > > Daniel Lezcano (3): > > > > thermal/acpi: Add ACPI trip point routines > > > > thermal/drivers/intel: Use generic trip points for intel_pch > > > > thermal/drivers/intel: Use generic trip points int340x > > > > > > > > drivers/thermal/Kconfig | 4 + > > > > drivers/thermal/Makefile | 1 + > > > > drivers/thermal/intel/Kconfig | 1 + > > > > drivers/thermal/intel/int340x_thermal/Kconfig | 1 + > > > > .../int340x_thermal/int340x_thermal_zone.c | 177 ++++----- > > > > -- > > > > -- > > > > -- > > > > .../int340x_thermal/int340x_thermal_zone.h | 10 +- > > > > drivers/thermal/intel/intel_pch_thermal.c | 88 ++------ > > > > drivers/thermal/thermal_acpi.c | 210 > > > > ++++++++++++++++++ > > > > include/linux/thermal.h | 8 + > > > > 9 files changed, 286 insertions(+), 214 deletions(-) > > > > create mode 100644 drivers/thermal/thermal_acpi.c > > > > >
