On 12/7/22 11:19 AM, Rafael J. Wysocki wrote:
On Tue, Dec 6, 2022 at 10:37 PM Luck, Tony <tony.luck@xxxxxxxxx> wrote:
Hi Ben,
The last patch I mentioned leaving out added support for injecting CXL
errors, but I don't have access to a machine that I can test it with at
the moment so it'll probably have to wait.
Parts 1 & 2 of your series can be applied now (as nice cleanups).
But part 3 would just be confusing to users without the matching patch
to add CXL injection support.
I.e. a user might
# cat /sys/kernel/debug/apei/einj/available_error_type
and see:
0x00001000 CXL.cache Protocol Correctable
But:
# echo 0x1000 > /sys/kernel/debug/apei/einj/error_type
wouldn't do anything useful (may do weird stuff since the driver
doesn't appear to validate the "type" ... would be great if you fixed
that while you are digging around in this code :-).
So I'm happy to offer up a "Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>"
for all three parts. I just think that part 3 should not be applied until the
rest of the code to go with it is ready.
I agree, so I've done accordingly.
Patches [1-2/3] have been applied as 6.2 material (with very minor
subject adjustments) and Ben please resend patch [3/3] when sending
the other material mentioned above (and please feel free to add the
tag from Tony to it when doing that).
Will do. Thanks for the review!
