Hi Ben, > The last patch I mentioned leaving out added support for injecting CXL > errors, but I don't have access to a machine that I can test it with at > the moment so it'll probably have to wait. Parts 1 & 2 of your series can be applied now (as nice cleanups). But part 3 would just be confusing to users without the matching patch to add CXL injection support. I.e. a user might # cat /sys/kernel/debug/apei/einj/available_error_type and see: 0x00001000 CXL.cache Protocol Correctable But: # echo 0x1000 > /sys/kernel/debug/apei/einj/error_type wouldn't do anything useful (may do weird stuff since the driver doesn't appear to validate the "type" ... would be great if you fixed that while you are digging around in this code :-). So I'm happy to offer up a "Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>" for all three parts. I just think that part 3 should not be applied until the rest of the code to go with it is ready. -Tony
