Hi, On 9/1/22 16:15, Arvid Norlander wrote: > Hi, > > On 2022-09-01 12:42, Hans de Goede wrote: >> Hi, >> > > <snip> > >> >> Great, thank you so much for testing this! >> >> Is it ok if I add a: >> >> Tested-by: Arvid Norlander <lkml@xxxxxxxxx> >> >> to the 2 patches for fixing this to give you credit for your testing ? > > Yes, of course. As a newcommer it is hard to learn and remember all these > little rules you have in kernel development. It is quite different from the > forge-based workflow I'm used to. No worries, I think you are doing great. Actually I could just have added your Tested-by tags if I wanted too. Only the Signed-off-by tag is one which you must explicitly give. But asking seemed like the polite thing to do :) >>> I'm not set up to test hibernation (using swap file on btrfs). Nor do I >>> know if it even works on this laptop. It has some sort of auto hibernate >>> feature in BIOS called Intel Rapid Start. It supposedly auto transitions to >>> hibernation after being asleep for a while. I have not looked into if this >>> is supported on Linux, and what setup would be required to support it in >>> that case. >> >> Regular suspend/resume testing is what I was looking for. On restore >> from hibernation the backlight is already on when restoring the state so >> I don't expect any problems there. And as you indicate getting hibernation >> to work is tricky in general, IMHO there is no need to go through all >> the trouble necessary to (maybe) get that to work. > > Hm, I have not found it tricky when I have had swap partitions. At least on > my Thinkpads as long as I avoid nvidia drivers. As long as you have large enough swap partitions, yes. Sometimes figuring out what large enough is is tricky though. Anyway we are getting offtopic. Regards, Hans
