Hi, On 2022-08-26 13:46, Hans de Goede wrote: > Hi All, > > [...] > > Arvid, I wonder if instead of using disable_backlight_sysfs_if > you can try: > > 0. Remove disable_backlight_sysfs_if from cmdline / quirk > 1. Adding acpi_backlight=native to the kernel commandline > 2. In toshiba_acpi_resume() add a HCI_PANEL_POWER_ON PANEL_ON > > and see if that also fixes things ? > Yes, this works. I do not have a patch for this (I assume it would involve creating quirk tables, checking for support for HCI_PANEL_POWER_ON, etc). I simply hard coded the call in for the test. I very much doubt I will have time to code this in the near future as well. However, do we know what the other Toshiba's that need this quirk also supports HCI_PANEL_POWER_ON? I obviously can only test the Z830 that I own. > If that is the case then we can: > > 1. Move the DMI quirks for disable_backlight_sysfs_if > from acpi_video.c to video_detect.c to force native > mode by quirk > 2. Add the DMI table with the models needing this to > toshiba_acpi.c and then based on that call > HCI_PANEL_POWER_ON PANEL_ON on resume from there > 3. Since there are no more quirks using it, remove the > disable_backlight_sysfs_if hack / workaround from > acpi_video.c > > This will give a nice-cleanup of the generic acpi_video.c > code moving the toshiba specific fixup to toshiba_acpi > where it really belongs. > > Regards, > > Hans > > Best regards, Arvid Norlander
