Re: [PATCH v2 7/8] ACPI: property: Add support for parsing buffer property UUID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On Fri, May 20, 2022 at 05:28:52PM +0300, Andy Shevchenko wrote:
> On Fri, May 20, 2022 at 09:11:47AM +0300, Sakari Ailus wrote:
> > Add support for newly added buffer property UUID, as defined in the DSD
> > guide.
> 
> ...
> 
> >  static bool acpi_enumerate_nondev_subnodes(acpi_handle scope,
> > -					   const union acpi_object *desc,
> > +					   union acpi_object *desc,
> >  					   struct acpi_device_data *data,
> >  					   struct fwnode_handle *parent);
> > -static bool acpi_extract_properties(const union acpi_object *desc,
> > +static bool acpi_extract_properties(acpi_handle handle,
> > +				    union acpi_object *desc,
> >  				    struct acpi_device_data *data);
> 
> Looking at the first one, can union member be const in the last one?

The object contains _DSD properties that will be changed if the properties
are of buffer type --- see acpi_data_add_buffer_props() in the same patch.

> 
> ...
> 
> >  struct acpi_device_properties {
> >  	const guid_t *guid;
> > -	const union acpi_object *properties;
> > +	union acpi_object *properties;
> 
> Probably this change explains on the above question...
> 
> >  	struct list_head list;
> > +	void **bufs;
> >  };

-- 
Kind regards,

Sakari Ailus



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux