Hi Muhammad, I love your patch! Perhaps something to improve: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on chrome-platform/for-next v5.18-rc5 next-20220506] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/platform-chrome-Add-ChromeOS-ACPI-device-driver/20220506-175951 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220506/202205062057.LDuKncYN-lkp@xxxxxxxxx/config) compiler: arceb-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4f6407962feddc57bc7c80e5b29d5d339a1dba6c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Muhammad-Usama-Anjum/platform-chrome-Add-ChromeOS-ACPI-device-driver/20220506-175951 git checkout 4f6407962feddc57bc7c80e5b29d5d339a1dba6c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/platform/chrome/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/acpi.h:15, from drivers/platform/chrome/chromeos_acpi.c:13: drivers/platform/chrome/chromeos_acpi.c: In function 'chromeos_acpi_device_probe': >> drivers/platform/chrome/chromeos_acpi.c:253:40: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'unsigned int' [-Wformat=] 253 | dev_warn(&(pdev->dev), "Only %ld GPIO attr groups supported by the driver out of total %d.\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap' 110 | _p_func(dev, fmt, ##__VA_ARGS__); \ | ^~~ include/linux/dev_printk.h:146:61: note: in expansion of macro 'dev_fmt' 146 | dev_printk_index_wrap(_dev_warn, KERN_WARNING, dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~ drivers/platform/chrome/chromeos_acpi.c:253:17: note: in expansion of macro 'dev_warn' 253 | dev_warn(&(pdev->dev), "Only %ld GPIO attr groups supported by the driver out of total %d.\n", | ^~~~~~~~ drivers/platform/chrome/chromeos_acpi.c:253:48: note: format string is defined here 253 | dev_warn(&(pdev->dev), "Only %ld GPIO attr groups supported by the driver out of total %d.\n", | ~~^ | | | long int | %d At top level: drivers/platform/chrome/chromeos_acpi.c:259:36: warning: 'chromeos_device_ids' defined but not used [-Wunused-const-variable=] 259 | static const struct acpi_device_id chromeos_device_ids[] = { | ^~~~~~~~~~~~~~~~~~~ vim +253 drivers/platform/chrome/chromeos_acpi.c 244 245 static int chromeos_acpi_device_probe(struct platform_device *pdev) 246 { 247 chromeos_acpi_gpio_groups = get_gpio_pkg_num(&pdev->dev); 248 249 /* If platform has more GPIO attribute groups than the number of 250 * groups this driver supports, give out a warning message. 251 */ 252 if (chromeos_acpi_gpio_groups > (ARRAY_SIZE(chromeos_acpi_all_groups) - 2)) > 253 dev_warn(&(pdev->dev), "Only %ld GPIO attr groups supported by the driver out of total %d.\n", 254 (ARRAY_SIZE(chromeos_acpi_all_groups) - 2), chromeos_acpi_gpio_groups); 255 return 0; 256 } 257 -- 0-DAY CI Kernel Test Service https://01.org/lkp
