Hi, On 4/28/22 08:24, Paul Gortmaker wrote: > There is only one user of pmc_atom_read in tree, and that is in > drivers/acpi/acpi_lpss.c -- which can't be anything but built-in. > > As such there is no point in adding this function to the global symbol > list exported to modules. > > Note that there is no <linux/export.h> include removal since the code > was getting that header implicitly. > > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Aubrey Li <aubrey.li@xxxxxxxxxxxxxxx> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx> > Cc: Mark Gross <markgross@xxxxxxxxxx> > Cc: platform-driver-x86@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/pmc_atom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c > index 31cf25d25d66..b8b1ed1406de 100644 > --- a/drivers/platform/x86/pmc_atom.c > +++ b/drivers/platform/x86/pmc_atom.c > @@ -221,7 +221,6 @@ int pmc_atom_read(int offset, u32 *value) > *value = pmc_reg_read(pmc, offset); > return 0; > } > -EXPORT_SYMBOL_GPL(pmc_atom_read); > > static void pmc_power_off(void) > {
