On Fri, 25 Mar 2022, Vishal Verma wrote:
+static acpi_status acpi_pci_query_osc(struct acpi_pci_root *root, u32 support, + u32 *control, u32 cxl_support, + u32 *cxl_control) { acpi_status status; - u32 result, capbuf[OSC_CXL_CAPABILITY_DWORDS]; + u32 pci_result, cxl_result, capbuf[OSC_CXL_CAPABILITY_DWORDS];
While the wasted stack is hardly an issue, I do find it annoying that capbuf will be bigger than necessary when is_cxl() == F, cap's pointer.length being capped at 12 bytes. Doing capbuf dynamically and allocating memory would obviously not be worth it. Bleh :/ Thanks, Davidlohr