Hi Vishal,
A few small comments below, but overall I like this series.
On Fri, 25 Mar 2022, Vishal Verma wrote:
+static u32 acpi_osc_ctx_get_pci_control(struct acpi_osc_context *context)
+{
+ u32 *ret = context->ret.pointer;
+
+ return ret[OSC_CONTROL_DWORD];
+}
Should this one go into a more generic acpi.h? For example, another user
could be acpi_bus_osc_negotiate_usb_control().
+
+static u32 acpi_osc_ctx_get_cxl_control(struct acpi_osc_context *context)
+{
+ u32 *ret = context->ret.pointer;
+
+ return ret[OSC_CXL_CONTROL_DWORD];
+}
... and perhaps this one too? But just for symmetry with the pci one, as there
are no users out side of pci_root.c. Both helpers want to be inline too. Btw
this probably also goes for the is_pci/cxl() helpers.
Thanks,
Davidlohr
