On Mon, Nov 01, 2021 at 02:16:41PM +0100, Greg Kroah-Hartman wrote: > On Mon, Nov 01, 2021 at 09:14:34PM +0800, Chen Yu wrote: > > On Mon, Nov 01, 2021 at 01:21:36PM +0200, Andy Shevchenko wrote: ... > > Ok, I'll switch to global variables in next version. > > Wait, no, why? But why should we have a duplication of basically static data? > Keep them per-device unless you can somehow be > guaranteed there will never be more than one of these ACPI devices in a > system. I guess you missed my point. These definitions are _always_ the same. It does not matter how many devices in the system. Chen, is my perception correct? If no, then do what Greg says. > It's simpler this way, no need to worry about global state at > all. Actually I have no idea why we even have strings in and not raw buffers. Moreover, I haven't got why even we have them in uAPI. -- With Best Regards, Andy Shevchenko
