On Tue, Jun 08, 2021 at 02:45:03PM +0300, Mika Westerberg wrote: > Hi, > > On Tue, Jun 08, 2021 at 11:50:15AM +0200, Hans de Goede wrote: > > Hi, > > > > On 6/7/21 9:18 PM, Hans de Goede wrote: > > > Hi, > > > > > > On 6/7/21 6:08 PM, Mika Westerberg wrote: > > >> Hi, > > >> > > >> Tried now on ADL-P and TGL systems and the _OSC still works properly. > > >> > > >> Thanks Hans for fixing! > > >> > > >> Feel free to add my Tested-by. > > > > > > Thank you for testing, unfortunately so far from the comments here: > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=213023 > > > > > > it seems that my patch does not help resolve the issues caused > > > by commit 719e1f561afb ("ACPI: Execute platform _OSC also with query > > > bit clear"), where as reverting that commit does resolve them :| > > > > > > Does anyone have any other ideas how to fix this ? > > > > The reporter who has done the bisect has commented out the new/second > > _OSC call and that fixes things for them. So I've written a new fix > > (attached), note just as before this is untested ATM. > > > > Mika, if you can test this one (it replaces the previous one) > > on machines with native USB4 support to check those don't regress then > > that would be great. > > I can test it sure, but first let's try to understand what the problem is :) FYI, I also tested your patch and it still works on my test system so if we decided to go with that then feel free to add my Tested-by to the patch too.