On Mon, Jun 7, 2021 at 12:05 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > HI, > > On 6/7/21 11:43 AM, Hans de Goede wrote: > > Hi, > > > > On 6/3/21 7:26 PM, Hans de Goede wrote: > >> Hi Rafael, > >> > >> I've been helping some users with trying to get to the bottom of some > >> new ACPI errors with kernel 5.12, see: > >> > >> https://bugzilla.kernel.org/show_bug.cgi?id=213023 > >> > >> After looking at dmesg output; and after editing the dmesg output > >> a bit so that I could do diff -u on it, the following stands out: > >> > >> --- dmesg_5.10.38-1-lts 2021-06-03 16:29:41.372922210 +0200 > >> +++ dmesg_linux-5.12.5-arch1-1 2021-06-03 16:30:01.013031634 +0200 > >> @@ -92,7 +92,7 @@ > >> ACPI: IRQ9 used by override. > >> Using ACPI (MADT) for SMP configuration information > >> ACPI: HPET id: 0x8086a201 base: 0xfed00000 > >> -ACPI: Core revision 20200925 > >> +ACPI: Core revision 20210105 > >> PM: Registering ACPI NVS region [mem 0x7156c000-0x7156cfff] (4096 bytes) > >> PM: Registering ACPI NVS region [mem 0x8a88f000-0x8af7efff] (7274496 bytes) > >> ACPI FADT declares the system doesn't support PCIe ASPM, so disable it > >> @@ -113,10 +113,6 @@ > >> ACPI: Dynamic OEM Table Load: > >> ACPI: SSDT 0xFFFF... 0003FF (v02 PmRef Cpu0Cst 00003001 INTL 20160527) > >> ACPI: Dynamic OEM Table Load: > >> -ACPI: SSDT 0xFFFF... 0000BA (v02 PmRef Cpu0Hwp 00003000 INTL 20160527) > >> -ACPI: Dynamic OEM Table Load: > >> -ACPI: SSDT 0xFFFF... 000628 (v02 PmRef HwpLvt 00003000 INTL 20160527) > >> -ACPI: Dynamic OEM Table Load: > >> ACPI: SSDT 0xFFFF... 000D14 (v02 PmRef ApIst 00003000 INTL 20160527) > >> ACPI: Dynamic OEM Table Load: > >> ACPI: SSDT 0xFFFF... 000317 (v02 PmRef ApHwp 00003000 INTL 20160527) > >> > >> Note how for some reason the kernel is no longer loading the Cpu0Hwp and > >> HwpLvt SSDT-s ? > >> > >> Do you have any ideas what might be causing this ? > > > > Good news, a very similar bug is being tracked here: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1963717 > > > > And one of the reporters there has done a git bisect and has found the commit which is causing the problem for them: > > > > """ > > git-bisect points to 719e1f561afbe020ed175825a9bd25ed62ed1697 : > > "ACPI: Execute platform _OSC also with query bit clear". > > > > Tested 5.12.9 kernel with the commit reverted, and confirmed that the error > > messages are gone. (I had to revert > > 5a6a2c0f0f43676df27632d657a3f18b151a7ef8 for dependency too.) > > > > It also brings back the /sys/devices/system/cpu/cpu0/acpi_cppc which is absent > > in the stable 5.12.x > > > > Hope this helps > > """ > > I've taken a quick look at commit 719e1f561afb ("ACPI: Execute platform _OSC also with query bit clear") and I think I may have found the problem. > > I've attached a patch which I think may fix this (and I've asked the reporters of the bugs to test this). Thank you, the patch looks reasonable to me. It looks like commit 719e1f561afb went a bit too far.