I think we need to wait for the confirmation from David. This looks good, but I'd like to see testing. I also wonder how many of the simple suspend quirks we can drop with this.
David, do you think you can get this soonish or are you similarly
blocked like Shyjumon by remote work restrictions? As this is causing
problems for a variety of already shipped OEM systems I would like to
see this series land for 5.14. If you can't get to it in time, I would
prefer that we switch this patch back to how it was conservatively done
in v1 for 5.14 (and redo 2/2 on top of that):
https://lore.kernel.org/linux-nvme/20210527113751.GB17266@xxxxxx/T/#t
and let you get back to the list when you can to optimize it "later".
Shyjumon and Jon, can you retests the platforms quirked in
1fae37accfc5 ("nvme/pci: Add sleep quirk for Samsung and Toshiba drives") with this fix?
Shyjumon>> Yes, I do agree we need to test this also. However the boards where which I had these issues are not in my remote access now (as the work frequency on this boards are less and also due to Covid situation),
It might take some time for me to test. I will update as soon as I can.
