On Sat, 2021-03-27 at 10:19 +0200, Andy Shevchenko wrote: > On Saturday, March 27, 2021, Xiaofei Tan <tanxiaofei@xxxxxxxxxx> wrote: > > > Fix some coding style issues reported by checkpatch.pl, including > > following types: > > > > WARNING: simple_strtol is obsolete, use kstrtol instead > > > And one more thing, the above message is bogus. Read what the comments in > the code says about use cases for simple_*() vs. kstrto*() ones. > > Joe? This check and message is nearly 10 years old and was appropriate for when it was implemented. kernel.h currently has: * Use these functions if and only if you cannot use kstrto<foo>, because So the message could be changed to something like: WARNING: simple_strtol should be used only when kstrtol can not be used.
