On Mon, 24 Dec 2007, Matthew Garrett wrote: > On Sun, Dec 23, 2007 at 12:00:57AM -0800, Andrew Morton wrote: > > > and /sys/class/backlight/thinkpad_screen/brightness is no longer present, so > > my `brightness' script no longer works. That, my friends, is a regression. > > The thinkpad_acpi brightness interface simply doesn't work correctly on > recent Thinkpads. The ACPI interface does, but the currently exported ui Yes, it does since 2.6.24-rc4. And since MUCH earlier in the out-of-tree develompent versions. What usually causes weird breakage is to have more than one of (Ubuntu hackage in HAL calling back into thinkpad-acpi, X.org, ACPI video) trying to respond to brightness up/down. And you *do* *have* to use the latest Lenovo BIOSes, too. Also, apparently now X.org knows how to tell the BIOS to not react to backlight changes, so you have to configure it properly (I don't know much about it), too. Matthew, btw, Dmitri approved the _NOTIFY keycodes, which need to be part of the solution re. backlight control in thinkpads. Are you intending to push a patch implementing them? As I said before, I am okay with that solution, as long as Dmitri accepted it, and I will use _NOTIFY keycodes in thinkpad-acpi when they become available. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html