On Wednesday, 4 July 2007 23:39, Pavel Machek wrote: > Hi! > > > > > Introduce the pm_power_off_prepare() callback that can be registered by the > > > > interested platforms in analogy with pm_idle() and pm_power_off(), used for > > > > preparing the system to power off (needed by ACPI). > > > > > > > > This allows us to drop acpi_sysclass and device_acpi that are only defined in > > > > order to register the ACPI power off preparation callback, which is needed by > > > > pm_power_off() registered in a much different way. > > > > > > Well, the acpi way works with more than one piece of code "listening" > > > for powerdowns... and does not seem that ugly to me. > > > > > > Okay, so accessing system_state is not _that_ nice... aha, and perhaps > > > I understand why 1/2 of this series is right... it called prepare for > > > S4 even when we had shutdown in /sys/power/disk, right? > > > > > > Hmm. Okay, I think I can ACK both of these patches, but ACPI people > > > should have chance to comment, and it probably needs to stay in -mm > > > for a while. > > > > Well, linux-acpi in on the CC list and I see no comments from them. :-) > > Hmm, that's bad. We can try adding "APM rocks" into subject line to > get their attetion or something... Well, I take the lack of comments as the lack of objections. ;-) Greetings, Rafael -- "Premature optimization is the root of all evil." - Donald Knuth - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
