Re: [RFC][PATCH 2/2] PM: Introduce pm_power_off_prepare

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, 4 July 2007 21:52, Pavel Machek wrote:
> On Sun 2007-07-01 20:54:31, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > 
> > Introduce the pm_power_off_prepare() callback that can be registered by the
> > interested platforms in analogy with pm_idle() and pm_power_off(), used for
> > preparing the system to power off (needed by ACPI).
> > 
> > This allows us to drop acpi_sysclass and device_acpi that are only defined in
> > order to register the ACPI power off preparation callback, which is needed by
> > pm_power_off() registered in a much different way.
> 
> Well, the acpi way works with more than one piece of code "listening"
> for powerdowns... and does not seem that ugly to me.
> 
> Okay, so accessing system_state is not _that_ nice... aha, and perhaps
> I understand why 1/2 of this series is right... it called prepare for
> S4 even when we had shutdown in /sys/power/disk, right?
> 
> Hmm. Okay, I think I can ACK both of these patches, but ACPI people
> should have chance to comment, and it probably needs to stay in -mm
> for a while.

Well, linux-acpi in on the CC list and I see no comments from them. :-)

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux