On Sun, May 27, 2007 at 06:44:49PM -0700, David Brownell wrote: > On Sunday 27 May 2007, Matthew Garrett wrote: > > Actually, it seems to be worse than that - the PNP entry for my cmos > > clock doesn't appear to mention an irq, so the wakealarm entry doesn't > > work. I can happily wake it using the /proc/acpi/alarm interface. > > > > David, would you be happy with hardcoding the rtc-cmos IRQ to 8 on PCs > > if there's inadequate PNP information available? > > That would seem to naturally belong in the PNP code, yes? > > Agreed that it seems like it needs to be hardcoded somewhere. The PNP code is reporting what's in the tables - I'd be a bit surprised if it special-cased specific devices, but I guess there's an argument for that. All the other machines I've checked report an IRQ, so I guess Apple just didn't take much care in getting this right. As far as sanity checking goes - how about we check that the reported io ports are the legacy range, and if so hardcode the irq if the hardware hasn't reported one? I'd /hope/ that nobody has produced any hardware that that would break, but then, well. The strongest argument for it being safe is probably that the legacy RTC driver seems to hardcode this and hasn't obviously been breaking things. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
