On Tue, Apr 10, 2007 at 04:13:43PM -0400, Len Brown wrote: > On Monday 09 April 2007 04:19, malattia@xxxxxxxx wrote: ... > >SONY_LAPTOP_OLD > > There is probably a better name for this -- like SONY_PI_COMPATIBILITY or something. ok, will change asap, I have a couple more patches here that I'll send in soon. > What about CONFIG_SONYPI? -- should it now depend on this driver not being included? So, all in all I'd like to obsolete sonypi as soon as possible to get more feedback but the 2 drivers can still live together for a while. When you try to load both 2 things can happen: - if you load sonypi first it will steal part of sony-laptop functionalities (the rewrite stuff for the SPIC acpi device) - if you load sony-laptop first sonypi will bomb out with kobject_add failed for sonypi with -EEXIST on misc_register(). sony-laptop also offers a no_spic option to not drive the SPIC device. The only function that sony-laptop doesn't offer is the motion eye camera stuff, which the meye driver also depend on and which makes sonypi useful at least for a couple of vaio models. I can add it to sony-laptop[1] but I can't test. I should probably add some printks in sonypi to suggest moving towards sony-laptop and try to detect if the known ioports are being used by sony-laptop to better handle the sonypi load failure (see below). [1]: there are some bits in the patches I submitted but I'll remove them with the next submission. > SONYPI depends on !64BIT -- is that invalid, or perhaps you only need the compatibility > stuff only in 32-bit mode? it's invalid. I'd rather avoid changing sonypi to work also on 64bit, for 64bit vaios the new sony-laptop should be good enough. > applied to acpi-test. Thanks! > It would be great if you can get some test feedback for the sonypi-era features > to make sure that the code moved into the new driver works as well as the old sonypi. I already asked a couple of users to try it and it seems to work well for them (and for their purposes). I guess obsoleting sonypi may increase the reports number ;) -- mattia :wq! - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
