On Tue, 27 Mar 2007 21:19:58 -0700 Greg KH <greg@xxxxxxxxx> wrote:
> On Wed, Mar 28, 2007 at 11:52:33AM +0800, Shaohua Li wrote:
> > +static void cpuidle_state_sysfs_release(struct kobject *kobj)
> > +{
> > + /* Nothing required to do here, just workaround kobject warning*/
> > +}
>
> NO!!!
heh. This happens rather a lot.
> Do people think that I add warnings to the kernel so that people can
> just work around them by passing empty functions to the driver core?
>
> Sometimes I wonder why I even try...
>
> Please fix this code, it is wrong.
>
Is it documented anywhere? I always forget the reasoning so I have to
cc you each time I see it happening.
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
