Karol and Julien are listed as the MAINTAINERS for asus_acpi. Why do I not see their Signed-off-by or Acked-by lines on this patch series? On Wednesday 20 December 2006 05:02, Corentin CHARY wrote: > Le mercredi 20 décembre 2006 08:42, Len Brown a écrit : > > On Tuesday 19 December 2006 16:17, Corentin CHARY wrote: > > > Hi, > > > This set of patch is against 2.6.19. It add support for many > > > models, /sys/class/backlight/, Light Sens, etc ... There is also a lot of > > > cleanups. And the most important, a new system to handle unsupported > > > models. > > > > > > Patch from 0 to 10 are change and cleanups in the driver. > > > Patch from 11t to 21 add support for new models. > > > > > > All the following patchs are available here : > > > <http://xf.iksaif.net/acpi4asus/2.6.19/> > > > > > > When this series is formatted to apply, what tree is it supposed to apply > > to? > These patchs are done with asus_acpi.c from 2.6.19 . So it can be applied to > 2.6.19 and 2.6.20-rc1 (as there is no change for asus_acpi in 2.6.20-rc1). > > > > > > How does it relate to the two asus_acpi patches in the mm tree right now -- > > 13/19 and 19/19 that akpm forwarded to the list yesterday. > > > The change in the mm tree are : > - Backlight support > => It's nearly the same code (patch 10/22) > - no more useless cast > => It's ok (patch 7/22) > - Add support for A6VA, M6V, W5F, V6V, A4S > => It's ok, but more features are supported in my patchs. > And the implemention is cleaner, as I use my parse_method() > function instead of adding special case in get_lcd_status() > (see patch 5/22 and 6/22) > - Swap W5A and W3V > => It's ok, (patch 19/22) > - Invert wled status > => I don't do it, as it's a mistake. I tested on A6T, A6J, F3JM, and the > wled value don't need to be inverted. So should we NAK the two patches that are proposed in -mm and ask Andrew to not accept asus_acpi patches and instead direct them to acpi4asus-user@xxxxxxxxxxxxxxxxxxxxx? > > How does it relate to the acpi-test tree, which already includes > > the backlight patch to asus_acpi from Holger Macht? > The change in the acpi-test tree are : > - Backlight support > => done > - no more useless cast > => done Holger's patch is already queued for upstream -- having lived in -mm for some time now. When you resend the acpi4asus series such that it is properly formatted, please be sure it applies cleanly to what is in acpi release tree. (ftp://ftp.kernel.org/pub/linux/kernel/people/lenb/acpi/patches/release/2.6.20/acpi-release-20060707-2.6.20-rc1.diff.gz) thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
