On Thursday 16 November 2006 10:22 pm, David Brownell wrote: > On Thursday 16 November 2006 7:41 am, Alexey Starikovskiy wrote: > > --- a/drivers/acpi/ec.c > > +++ b/drivers/acpi/ec.c > > @@ -467,8 +467,8 @@ static u32 acpi_ec_gpe_handler(void *dat > > status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec); > > } > > acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR); > > - return status == AE_OK ? > > - ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED; > > + WARN_ON(ACPI_FAILURE(status)); > > + return ACPI_INTERRUPT_HANDLED; > > } > > > > Strange ... applying this on top of the previous patch seems to work > much better, but that WARN_ON hasn't triggered. At least, not yet. > Updating to RC6, with your two patches installed... ACPI Exception (evregion-0424): AE_TIME, Returned by Handler for [EmbeddedControl] [20060707] ACPI Exception (dswexec-0458): AE_TIME, While resolving operands for [OpcodeName unavailable] [2006070 7] ACPI Error (psparse-0537): Method parse/execution failed [\_TZ_.THRM._TMP] (Node ffff810002032d10), AE _TIME OK, I don't get the WARN_ON when these happen, so it's got to be one of the other EC updates. It'd be nice if this were easily reproducible ... - Dave - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
