Re: [patch 10/13] Remove acpi_os_create_lock(), acpi_os_delete_lock()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2 Jun 2006 12:09:14 -0700
"Moore, Robert" <robert.moore@xxxxxxxxx> wrote:

> This will not always be the case, in fact we are about to expand the use
> of the spinlock interfaces.

Sure, but this function is absolutely crackers.  All it does is to
dynamically allocate and initialise a spinlock.  But the storage for the
pointer-to-spinlock is the same as, or larger than the spinlock itself.

This thing has to die - please kill it before it spreads.  The spinlock
should be aggregated by value into the containing structure.  Not by
reference.

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux