As currently written, I think it's safe to call it. The sdt_entry table will be empty if the user specified 'acpi=off', so the function will return 0. Andy > -----Original Message----- > From: Andi Kleen [mailto:ak@xxxxxx] > Sent: Thursday, June 01, 2006 20:48 > To: akpm@xxxxxxxx > Cc: len.brown@xxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; Andy > Currid; luming.yu@xxxxxxxxx > Subject: Re: [patch 12/13] Fix HPET operation on 64-bit > NVIDIA platforms > > > > #ifdef CONFIG_ACPI > > - /* All timer overrides on Nvidia > > - seem to be wrong. > Skip them. */ > > - acpi_skip_timer_override = 1; > > - printk(KERN_INFO > > - "Nvidia board detected. Ignoring ACPI timer override.\n"); > > + /* > > + * All timer overrides > on Nvidia are > > + * wrong unless HPET is enabled. > > + */ > > + nvidia_hpet_detected = 0; > > + acpi_table_parse(ACPI_HPET, > > + > nvidia_hpet_check); > > I'm not sure it's safe to call acpi_table_parse() when the > user passed acpi=off > > Better would be probably to set a flag in the HPET callback > in arch/i386/kernel/acpi/boot.c > > -Andi > ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ----------------------------------------------------------------------------------- - To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
