Re: [patch 17/26] acpi: ia64: wake on LAN fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ueimor,

At Fri, 31 Mar 2006 23:26:33 +0200,
Francois Romieu wrote:
> 
> akpm@xxxxxxxx <akpm@xxxxxxxx> :
> > 
> > From: Satoru Takeuchi <takeuchi_satoru@xxxxxxxxxxxxxx>
> > 
> > Currently wakeup capability is available if and only if
> > CONFIG_ACPI_SLEEP=y.  But S5 is not a sleep state.  This patch makes ACPI
> > subsystem to be able to wakeup from S5 state even if sleep mode is not
> > supported.
> [...]
> > diff -puN drivers/acpi/sleep/Makefile~acpi-ia64-wake-on-lan-fix drivers/acpi/sleep/Makefile
> > --- devel/drivers/acpi/sleep/Makefile~acpi-ia64-wake-on-lan-fix	2006-03-28 14:03:06.000000000 -0800
> > +++ devel-akpm/drivers/acpi/sleep/Makefile	2006-03-28 14:03:06.000000000 -0800
> > @@ -1,5 +1,4 @@
> > -obj-y					:= poweroff.o wakeup.o
> > +obj-y					:= poweroff.o wakeup.o proc.o
> >  obj-$(CONFIG_ACPI_SLEEP)		+= main.o
> > -obj-$(CONFIG_ACPI_SLEEP_PROC_FS)	+= proc.o
> 
> $ less drivers/acpi/Kconfig
> [...]
> config ACPI_SLEEP_PROC_SLEEP
>         bool "/proc/acpi/sleep (deprecated)"
>         depends on ACPI_SLEEP_PROC_FS
> 
> The current patch would always build in a deprecated feature, right ?

No. proc.c is always compiled, but the code relevant to /proc/acpi/sleep
is not always built in.

If ACPI_SLEEP_PROC_SLEEP is not defined, that code snip is not compiled
because of #ifdef guard on proc.c.  On i386 system, you can select y/n
of ACPI_SLEEP_PROC_SLEEP.  On ia64 system, ACPI_SLEEP_PROC_SLEEP is not
defined because ACPI_SLEEP (and ACPI_SLEEP_PROC_FS) is always `n'.

Thanks,

Satoru Takeuchi
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux