All,
First, a correction. The patches I supplied didn't break the
backward compatibility in this particular case. The patches
were against the "4mdv" tarball available at the Zsolt's site.
The "4mdv" has the serial26.c file with the following code
around the line 990:
<<<<
receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
{
struct tty_struct *tty = up->port.info->port.tty;
>>>>
The older kernels (< 2.6.26) will not compile that, because they have a
different definition of the struct uart_info. Those interested in the older
kernels may have better luck with the "2mdv" sources (agrsm-2.1.80-2mdv2009.0.src.rpm).
This is how the same code looks in the "2mdv" serial26.c:
<<<<
receive_chars(struct uart_8250_port *up, int *status, struct pt_regs *regs)
{
struct tty_struct *tty = up->port.info->tty;
>>>>
Second, a clarification. The patches I posted to the list do not add support for
more chipsets. They 1) do a little clean up of the source build system, 2) get
rid of some warning messages that clutter the output, and 3) make it so that the
sources build successfully for the more recent kernels.
Note also that "build successfully" does not necessarily mean "function
properly". I've built them against 2.6.{27,28,29} and verified that wvdialconf
reports success. I didn't do any more testing beyond that.
So, if the "2mdv"/"4mdv" sources didn't support your chipsets, the "7mdv" is not
likely to support them either.
Testing was needed to verify that the "7mdv" didn't break anything that was
working before in the "2mdv"/"4mdv" sources. Also, Marvin injected the 630 (or
was it 620?) chipset along with my patch in the hopes that it might just work
[as it sometimes do] but it didn't.
Martin,
The patch is not coming yet, I will get back to this issue in a few days.
--
WBR, Nikolay Zhuravlev
Thus spake Marvin Stodolsky (marvin.stodolsky@xxxxxxxxx):
> Martin,
>
> The error you report:
> agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/serial26.c: In
> function ‘receive_chars’:
> agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/serial26.c:990: error:
> ‘struct uart_info’ has no member named ‘port’
>
> was reproduced using Ubuntu linux-headers-2.6.25-2-386.]
> However per example below, compiled were fine with both
> 2.6.28-11-generic and 2.6.27-11-generic linux-header resources. So it
> appears that the recent fixes Nikolay did broke backward compatible
> with kernels earlier than 2.6.7.
>
> Nikolay can likely fix this easily. Or perhaps you can upgrade to a
> 2.6.27 kernel.
> Also, you could try using the serial26.c from the prior
> dkms--agrsm-2.1.80-?mdv series package
>
> MarvS
>
> make[1]: Entering directory `/usr/src/linux-headers-2.6.28-11-genericr
> CC [M] /usr/src/agrsm-2.1.80-7mdv2009.0/agrsoftmodem.o
> SHIPPED /usr/src/agrsm-2.1.80-7mdv2009.0/agrmodemlib.o
> CC [M] /usr/src/agrsm-2.1.80-7mdv2009.0/HDA.o
> CC [M] /usr/src/agrsm-2.1.80-7mdv2009.0/serial26.o
> LD [M] /usr/src/agrsm-2.1.80-7mdv2009.0/agrmodem.o
> LD [M] /usr/src/agrsm-2.1.80-7mdv2009.0/agrserial.o
> Building modules, stage 2.
> MODPOST 2 modules
> WARNING: could not find
> /usr/src/agrsm-2.1.80-7mdv2009.0/.agrmodemlib.o.cmd for
> /usr/src/agrsm-2.1.80-7mdv2009.0/agrmodemlib.o
> CC /usr/src/agrsm-2.1.80-7mdv2009.0/agrmodem.mod.o
> LD [M] /usr/src/agrsm-2.1.80-7mdv2009.0/agrmodem.ko
> CC /usr/src/agrsm-2.1.80-7mdv2009.0/agrserial.mod.o
> LD [M] /usr/src/agrsm-2.1.80-7mdv2009.0/agrserial.ko
> make[1]: Leaving directory `/usr/src/linux-headers-2.6.28-11-generic'
>
>
>
> On Sat, May 23, 2009 at 10:31 AM, Martin Lupcke
> <mossianin_lbcmi@xxxxxxxxxx> wrote:
> > I tried installing the latest "7mdv" driver from about May 19. I saw at one
> > point that there was not a lot of optimism, but I tried anyway. The install
> > process failed on the make command. The output of that is below.
> > ===Start of output===
> > make
> > make -C /lib/modules/2.6.26.8.tex3/build
> > M=/A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0
> > modules
> > make[1]: Entering directory `/usr/src/linux-2.6.26.8.tex3'
> > CC [M]
> > /A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/agrsoftmodem.o
> > CC [M]
> > /A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/HDA.o
> > CC [M]
> > /A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/serial26.o
> > /A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/serial26.c:
> > In function ‘receive_chars’:
> > /A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/serial26.c:990:
> > error: ‘struct uart_info’ has no member named ‘port’
> > make[2]: ***
> > [/A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0/serial26.o]
> > Error 1
> > make[1]: ***
> > [_module_/A_DownloadUpdates/AgereModeminEMachines/agrsm-2.1.80-7mdv2009.0/agrsm-2.1.80-7mdv2009.0]
> > Error 2
> > make[1]: Leaving directory `/usr/src/linux-2.6.26.8.tex3'
> > make: *** [default] Error 2
> > ===End of output
> >
> > Any guidance on a where to go from here would be appreciated. Hopefully,
> > this might help in the great work all of you are doing on this.
> > Thanks.
> >
> >
> > Antonio Olivares wrote:
> >>
> >> I used the new source with the fix in place, I get kernel panic again :
> >>
> >>
> >> http://www.slax.org/forum.php?action=view&parentID=39934&anchorid=40035#postid40035
> >>
> >> Regards,
> >>
> >> Antonio
> >>
> >> On 5/19/09, Marvin Stodolsky <marvin.stodolsky@xxxxxxxxx> wrote:
> >>
> >>>
> >>> The setup is fixed in the attached.
> >>>
> >>> MarvS
> >>>
> >>> On Sun, May 17, 2009 at 9:37 PM, Marvin Stodolsky
> >>> <marvin.stodolsky@xxxxxxxxx> wrote:
> >>>
> >>>>
> >>>> Jacques hasn't mounted these packages as yet, so I'm sending direct to
> >>>> you.
> >>>> For usage of the dkms-agrsm package, first install dkms support.
> >>>> Then do:
> >>>> $ sudo dpkg -i dkms-agrsm*.deb
> >>>> Then test the drivers as before. A reboot may be necessary.
> >>>> Please report to Discuss@xxxxxxxxxxxxxx
> >>>> Not directly to me.
> >>>>
> >>>> MarvS
> >>>>
> >>>>
> >>>> ---------- Forwarded message ----------
> >>>> From: Marvin Stodolsky <marvin.stodolsky@xxxxxxxxx>
> >>>> Date: Sun, May 17, 2009 at 12:18 AM
> >>>> Subject: Fwd: testing needed for dkms-agrsm-2.1.80-7mdv2009.0
> >>>> To: Jacques Goldberg <Jacques.Goldberg@xxxxxxx>, Antonio Olivares
> >>>> <olivares14031@xxxxxxxxx>, Zsolt BÉRCZES <zsolt@xxxxxx>
> >>>>
> >>>>
> >>>> Jacques
> >>>>
> >>>> For http://linmodems.technion.ac.il/packages/ltmodem/11c11040/
> >>>>
> >>>> MarvS
> >>>>
> >>>>
> >>>> ---------- Forwarded message ----------
> >>>> From: Marvin Stodolsky <marvin.stodolsky@xxxxxxxxx>
> >>>> Date: Sun, May 17, 2009 at 12:12 AM
> >>>> Subject: testing needed for dkms-agrsm-2.1.80-7mdv2009.0
> >>>> To: Linmodems <discuss@xxxxxxxxxxxxx>
> >>>>
> >>>>
> >>>> The code with Nikolay's patches installed has been assembled in
> >>>> packages
> >>>> dkms-agrsm-2.1.80-7mdv2009.0.tar.gz
> >>>> dkms-agrsm_2.1.80-7_i386.deb
> >>>> and are being sent to Jacques for mounting in
> >>>> http://linmodems.technion.ac.il/packages/ltmodem/11c11040/
> >>>> whereat useful companion packages are the agrsm-tools and
> >>>> agrsm_howto.txt
> >>>>
> >>>>
> >>>> Prior installation of dkms support is necessary.
> >>>> Install the deb package in Ubuntu with:
> >>>> $ sudo dkms*.deb
> >>>>
> >>>> For other distros
> >>>> The dkms-agrsm-2.1.80-7mdv2009.0.tar.gz has a setup file to be
> >>>> executed with Rood/Adm permission as:
> >>>> ./setup
> >>>>
> >>>> Zsolt will likely make a comparable RPM installer which will be
> >>>> available presently at
> >>>> http://linux.zsolttech.com/linmodem/agrsm/
> >>>>
> >>>> MarvS
> >>>>
> >>>> ---------- Forwarded message ----------
> >>>> From: Nikolay Zhuravlev <xxor@xxxxxxx>
> >>>> Date: 2009/5/16
> >>>> Subject: Re: [PATCH] Re: dkms-agrsm-2.1.80-2mdv2009.0.i586.rpm fails
> >>>> with kernel >= 2.6.29.X
> >>>> To: Marvin Stodolsky <marvin.stodolsky@xxxxxxxxx>
> >>>> Cc: Linmodems <discuss@xxxxxxxxxxxxx>
> >>>>
> >>>>
> >>>> Marvin,
> >>>>
> >>>> Ok, I see where the problem is. Here is the patch updated for 2.6.28
> >>>> along with
> >>>> some further improvements. This time it is against the
> >>>> agrsm-2.1.80-6mdv2009.0.tar.gz sources tarball you sent me on May 14.
> >>>>
> >>>> I have installed 2.6.28.10 and built the driver successfully. The
> >>>> wvdialconf
> >>>> runs fine, too.
> >>>>
> >>>> I am not sure what 2.6.28.11 is, I couldn't find it on ftp.kernel.org.
> >>>> I
> >>>> hope
> >>>> it is close enough to 2.6.28.10.
> >>>>
> >>>> --
> >>>> WBR, Nikolay Zhuravlev
> >>>>
> >>>> Thus spake Marvin Stodolsky (marvin.stodolsky@xxxxxxxxx):
> >>>>
> >>>>
> >>>>>
> >>>>> Nikolay,
> >>>>>
> >>>>> There is the problem below under Ubuntu 2.6.28-11-generic , last
> >>>>> paragraph below.
> >>>>>
> >>>>> However the compile is OK with your prior patch applied to
> >>>>> agrsm-2.1.80-6mdv2009.0, resulting in the
> >>>>> agrsm-2.1.80-6mdv2009.0.tar.gz, I sent you earlier.
> >>>>>
> >>>>> MarvS
> >>>>>
> >>>>> $ patch -p0 < 4mdv_2.6.29.1.patch
> >>>>> patching file agrsm-2.1.80-4mdv2009.0/agrsoftmodem.c
> >>>>> patching file agrsm-2.1.80-4mdv2009.0/HDA.c
> >>>>> patching file agrsm-2.1.80-4mdv2009.0/hda_codec.h
> >>>>> patching file agrsm-2.1.80-4mdv2009.0/Kbuild
> >>>>> patching file agrsm-2.1.80-4mdv2009.0/Makefile
> >>>>>
> >>>>> agrsm-2.1.80-4mdv2009.0$ make
> >>>>> make -C /lib/modules/2.6.28-11-generic/build
> >>>>> M=/usr/src/pkg/agrsm/agrsm-2.1.80-4mdv2009.0 modules
> >>>>> make[1]: Entering directory `/usr/src/linux-headers-2.6.28-11-generic'
> >>>>> CC [M] /usr/src/pkg/agrsm/agrsm-2.1.80-4mdv2009.0/agrsoftmodem.o
> >>>>> /usr/src/pkg/agrsm/agrsm-2.1.80-4mdv2009.0/agrsoftmodem.c: In function
> >>>>> ‘x_request_region’:
> >>>>> /usr/src/pkg/agrsm/agrsm-2.1.80-4mdv2009.0/agrsoftmodem.c:276: error:
> >>>>> too many arguments to function ‘__request_region’
> >>>>> make[2]: ***
> >>>>> [/usr/src/pkg/agrsm/agrsm-2.1.80-4mdv2009.0/agrsoftmodem.o]
> >>>>> Error 1
> >>>>> make[1]: *** [_module_/usr/src/pkg/agrsm/agrsm-2.1.80-4mdv2009.0] Error
> >>>>> 2
> >>>>> make[1]: Leaving directory `/usr/src/linux-headers-2.6.28-11-generic'
> >>>>> make: *** [default] Error 2
> >>>>>
> >>>>>
> >>>>> On Sat, May 16, 2009 at 8:52 AM, Nikolay Zhuravlev <xxor@xxxxxxx>
> >>>>> wrote:
> >>>>>
> >>>>>>
> >>>>>> Bjorn/All,
> >>>>>>
> >>>>>> I played with the source a bit more this morning. This is the patch
> >>>>>> against
> >>>>>> the agrsm-2.1.80-4mdv2009.0.tgz sources available at the Zsolt's
> >>>>>> site.
> >>>>>>
> >>>>>> It does two things:
> >>>>>> (1) Adds support for the 2.6.27-rc9, 2.6.29.1 (and maybe 2.6.28)
> >>>>>> kernel
> >>>>>> (2) Changes the Makefile to use the standard 2.6 kbuild procedure
> >>>>>> used for the linux modules [described in
> >>>>>> Documentation/kbuild/modules.txt]
> >>>>>>
> >>>>>> Before applying the patch and running make, please rename the file
> >>>>>> agrmodemlib.o to agrmodemlib.o_shipped . This will help the kbuild
> >>>>>> to recognize this is a pre-build binary coming from elsewhere,
> >>>>>> so that 'make clean' will not destroy it.
> >>>>>>
> >>>>>> After the patch, build & install like this:
> >>>>>>
> >>>>>> $ sudo modprobe -r agrserial
> >>>>>> $ sudo modprobe -r agrmodem
> >>>>>> $ make
> >>>>>> $ sudo make modules_install
> >>>>>> $ sudo modprobe agrmodem
> >>>>>> $ sudo modprobe agrserial
> >>>>>> $ sudo ln -s /dev/ttyAGS3 /dev/ttySAGR
> >>>>>> $ sudo wvdialconf /etc/wvdial.conf
> >>>>>>
> >>>>>> wvdialconf was successful on my notebook that has the 11c11040 chip on
> >>>>>> HDA, but
> >>>>>> I cannot test beyond that -- I don't have an actual phone line here.
> >>>>>>
> >>>>>> --
> >>>>>> WBR, Nikolay Zhuravlev
> >>>>>>
> >>>>>> Thus spake Bjorn Wielens (Uniacke1@xxxxxxxx):
> >>>>>>
> >>>>>>
> >>>>>>>
> >>>>>>> Hi,
> >>>>>>> Zsolt's sources are confirmed to work with 2.6.27 kernels.
> >>>>>>> However, we are still unsure about 2.6.28, and I will be able to try
> >>>>>>> and
> >>>>>>> experiment with 2.6.29 as soon as I can locate the correct packages
> >>>>>>> for
> >>>>>>> my distro.
> >>>>>>> You are likely correct about the problem, but there may be other
> >>>>>>> issues
> >>>>>>> as well.
> >>>>>>> Bjorn.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> Nikolay Zhuravlev wrote:
> >>>>>>>
> >>>>>>>>
> >>>>>>>> Antonio,
> >>>>>>>>
> >>>>>>>> Those sources are too old to work with the kernels >= 2.6.27
> >>>>>>>>
> >>>>>>>> You may want to have a look at the sources located at
> >>>>>>>> http://linux.zsolttech.com/linmodem/agrsm/ and hack those with
> >>>>>>>> the patch I attach here. I used it to get the driver working
> >>>>>>>> with the 2.6.27-rc9 kernel.
> >>>>>>>> Note that the patched sources may build and still not work with
> >>>>>>>> the recent kernels (28 and higher).
> >>>>>>>>
> >>>>>>>> I guess the HDA.c stuff in that driver is out of sync with
> >>>>>>>> the current ALSA developments in the 29 kernel anyway.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>
> >>>>>>
> >>
> >>
> >
