ESC meeting minutes: 2024-05-09

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Cloph, Gabriel, Heiko, Hossein, Ilmari, Jonathan, Olivier, Xisco, sockseight, Caolan, Stephane, Miklos

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
    + 7.6: 7.6.7 release: this week, tomorrow
    + 24.2: 24.2.4 RC1 in 1 week
    + 24.8: first alpha this week, from master, tomorrow
      + week 23 is the feature freeze, 4 weeks
        + string / UI freeze 4 weeks after that
      + if you have a late feature proposal, announce that here
    + MAR-based updater will be enabled by default on Windows, but not Linux (Hossein)
      + rpm/deb update is handled by distro packages
      + for the ones taking binaries from TDF
      + TDF to provide rpm/deb repos?
      + the files are hosted already
      + just the repo defs are missing
      + suggesting to provide these repos
      + proposal is to povide repos and ignore MAR on Linux for now
      + interested in doing the scripting work? (Miklos)
        + the important part is the description / dependencies (Hossein)
        + willing to help
      + linux downloads are 2% of TDF downloads (Cloph)
        + so not a huge amount, but not objecting
        + only the the ones which are covered by rpm/deb binaries
      + what is the lag between Ubuntu-provided packages / TDF releases? (Olivier)
        + the package from Ubuntu follows TDF quickly
        + similar with Debian, thanks to Rene (Cloph)
          + with actively supported versions
        + see LibreOffice 7.3.7 for Ubuntu 22.04 https://packages.ubuntu.com/jammy/libreoffice (Hossein)

* Documentation (Olivier)
    + Helpcontents2
       + Updates and fixes (A Gelmini. S. Horacek, fitoshido)
       + Changes in makefiles (cloph)
       + Updates in doc properties (Dublin Core) by Dione Maddern
    + Core
       + Extended tips for sparklines
    + Guides
       + important fix by M. Stahl will trigger format review
          + in all guides,
          + starting after LO 24.2.4
          + tdf#159366
    + bugs with >20 comments
      + hard to follow, to understand what is the actual request
      + sometimes asking: if this feature is still used
      + thanks to the precise bugreports
    + Bugzilla Documentation statistics
        263(263) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     14(5)    39(2)     107(7)     225(4)
         commented     20(10)   61(0)     255(5)     854(6)
          resolved      7(2)    23(5)      54(6)     121(4)
    + top 10 contributors:
          Olivier Hallot made 42 changes in 1 month, and 239 changes in 1 year
          Stéphane Guillou made 28 changes in 1 month, and 253 changes in 1 year
          Vernon, Stuart Foote made 22 changes in 1 month, and 107 changes in 1 year
          Ilmari Lauhakangas made 10 changes in 1 month, and 73 changes in 1 year
          Kaganski, Mike made 8 changes in 1 month, and 74 changes in 1 year
          Nabet, Julien made 6 changes in 1 month, and 59 changes in 1 year
          Cor Nouws made 5 changes in 1 month, and 8 changes in 1 year
          Heiko Tietze made 4 changes in 1 month, and 76 changes in 1 year
          nobu made 4 changes in 1 month, and 16 changes in 1 year
          Kira Tubo made 2 changes in 1 month, and 2 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        240(240) (topicUI) bugs open, 35(35) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added      4(-1)    10(1)     15(-1)      21(-3)
         commented     64(48)   186(30)   525(-6)    1761(-60)
           removed      0(-2)     4(-1)     5(0)       12(-1)
          resolved      8(2)     31(1)     79(-2)     308(-7)
    + top 10 contributors:
          Heiko Tietze made 110 changes in 1 month, and 1031 changes in 1 year
          Vernon, Stuart Foote made 108 changes in 1 month, and 317 changes in 1 year
          Stéphane Guillou made 51 changes in 1 month, and 621 changes in 1 year
          Cor Nouws made 21 changes in 1 month, and 33 changes in 1 year
          Dieter made 18 changes in 1 month, and 139 changes in 1 year
          Ilmari Lauhakangas made 16 changes in 1 month, and 131 changes in 1 year
          Eyal Rozenberg made 10 changes in 1 month, and 125 changes in 1 year
          Ady made 6 changes in 1 month, and 122 changes in 1 year
          jan d made 5 changes in 1 month, and 5 changes in 1 year
          *UNKNOWN* made 5 changes in 1 month, and 5 changes in 1 year
    + [Bug 161002] Missing item "Insert/Filed/More Fields.." in LibreOffice Draw
    + [Bug 160986] show 'X %' instead of 'X%'
    + [Bug 153309] Prevent direct formatting on writer by a password.
 -> + [Bug 98902] Right clicking on selected text unselects it if the cursor is on
           a misspelled word
    + [Bug 160955] When selecting an alternative link target for an OLE object, button
          says "Insert"
    + [Bug 160954] Can't change OLE Object link target from context menu and
           properties dialog
    + [Bug 160949] When editing an OLE object but not taking any action - undo edit
    + [Bug 160950] Warn before performing a destructive/lossy edit of OLE object
    + [Bug 146448] DOCX: A drawing object has a "Remove Textbox" which creates an
           empty frame (Captionbox/image frame is converted to Drawing object)
    + [Bug 158526] page number display in the status bar
    + [Bug 160920] Allow choosing the page style from the sheets tab
    + [Bug 160908] "Edit cell background highlight"

    + Vertical tabs https://bugs.documentfoundation.org/show_bug.cgi?id=99528
      + many dialogs with many tabs are now changed to use vertical tabs
      + recent change by Samuel
      + concern if this will be 100% by the time 24.8 is out (Xisco)
      + more afraid if these vertical tabs work nicely in so many dialogs (Heiko)
        + think of macOS, Windows, etc.
      + https://conference.libreoffice.org/assets/Conference/Almeria/Caolan-2019-NativeGtk.pdf I tried a few variations of tab placement before, but maybe more luck this time (Caolan)
        + a slide mentions the dialog with the most tabs, some 16, won't fit even the left-hand-side
      + sounds similar to the German shortcuts topic (Xisco)
        + would be good to have consensus here, before going further
      + ask the design team to provide input? (Miklos)
        + people interested in the topic are informed (Heiko)
        + the change was kind of welcome
        + looks great on Gnome, broken with kf5
          + looks more like a list, not tabs
          + macOS/Windows need checking
          + to make it really appealing, needs more work, though
          + expect a lot of effort should come after the first commits are in
        + also consider the doc team's work to update screenshots (Olivier)
        + but if all work is done, it may be a nice fresh look (Heiko)
          + indeed, looks nice (Olivier)
        + so this is welcome, but very much error-prone (Heiko)
AI: invite Samuel next week if there are still burning fires (Heiko)

* Crash Testing (Caolan)
    + 24(-39) import failure, 20(-39) export failures
     - https://wiki.documentfoundation.org/Development/Crashtesting is useful again
    + 1 coverity issue
     - just hit the weird possible coverity misunderstanding of virtual base warnings with a hammer
    + 6 ossfuzz issues
     - 5 timeouts, 1 new crash in 3rd party lib

* Crash Reporting (Xisco)
    + 7.6.5.2    10647(+840)
    + 7.6.6.3    4068(+1124)
    + 24.2.0.3    17369(+591)
    + 24.2.1.2    13738(+798)
    + 24.2.2.2    8930(+1873)
    + 24.2.3.2    487(+0)

    + https://crashreport.libreoffice.org/stats/signature/static%20bool%20%60anonymous%20namespace'::IsAllHiddenRow(const%20class%20SwRowFrame%20&%20const,%20const%20class%20SwTabFrame%20&%20const)

        - Fixed in 24.2.3.2. Thanks to Michael S.


     + https://crashreport.libreoffice.org/stats/signature/static%20%20%60com::sun::star::document::DocumentProperties::create'::%601'::catch$14()

    - New in 24.2 branch. Most reported crash atm


* Mentoring (Hossein)
 + New EasyHack
   tdf#160992 - Fix DPI dependent tests
   https://bugs.documentfoundation.org/show_bug.cgi?id=160992
          committer...   1 week     1 month     3 months    12 months
                  open      81(-11)    142(-21)    178(-17)     178(-17)
               reviews     450(100)   1206(56)    3718(76)    12462(22)
                merged     350(51)    1140(127)   3369(127)   12593(81)
             abandoned      13(4)       55(-2)     172(-2)      656(-1)
           own commits     250(27)     827(103)   2303(119)    9229(1)
        review commits      51(3)      224(-8)     871(14)     3012(-51)
        contributor...   1 week     1 month     3 months    12 months
                  open      37(4)       77(7)      103(8)       103(8)
               reviews     962(132)   2774(178)   7906(220)   29522(6)
                merged      23(3)       98(-20)    385(5)      1635(-61)
             abandoned       9(-4)      49(-5)     288(-10)     704(-3)
           own commits      25(0)      105(-8)     449(10)     1126(-7)
        review commits       0(0)        0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 326(326)
       total 408(408)   assigned 26(26)   open 348(348)
    + top 10 contributors:
          Armin Le Grand (allotropia) made 7 patches in 1 month, and 87 patches in 1 year
          Ritobroto Mukherjee made 5 patches in 1 month, and 15 patches in 1 year
            made 4 patches in 1 month, and 7 patches in 1 year
          Kira Tubo made 4 patches in 1 month, and 14 patches in 1 year
          Jakub Kościelak made 4 patches in 1 month, and 4 patches in 1 year
          colton Garrett made 4 patches in 1 month, and 4 patches in 1 year
          Stéphane Guillou made 3 patches in 1 month, and 7 patches in 1 year
          Stéphane Guillou made 3 patches in 1 month, and 58 patches in 1 year
          Sahil Gautam made 3 patches in 1 month, and 4 patches in 1 year
          Jonathan Clark made 3 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Adolfo Jayme Barrientos made 106 review comments in 1 month, and 512 in 1 year
          Ilmari Lauhakangas made 102 review comments in 1 month, and 548 in 1 year
          Hossein made 86 review comments in 1 month, and 338 in 1 year
          Caolán McNamara made 84 review comments in 1 month, and 1440 in 1 year
          Michael Stahl made 80 review comments in 1 month, and 920 in 1 year
          Thorsten Behrens made 70 review comments in 1 month, and 596 in 1 year
          Grandin, Noel made 64 review comments in 1 month, and 698 in 1 year
          Kaganski, Mike made 56 review comments in 1 month, and 472 in 1 year
          Vajna, Miklos made 56 review comments in 1 month, and 1078 in 1 year
          Christian Lohmaier made 56 review comments in 1 month, and 362 in 1 year
    + Patches automatically abandoned:
        basegfx: BColorStops shouldn't derive from std::vector ( Tomaž Vajngerl )
            - https://gerrit.libreoffice.org/#/c/158710
        tdf#114441 change use of sal_uLong to better integer types ( Achintya Sharma )
            - https://gerrit.libreoffice.org/#/c/159028
        wip: don't typedetect ole before load ( Caolán McNamara )
            - https://gerrit.libreoffice.org/#/c/161084
        tdf#155856 Added cmake to DocumentLoader example ( Konstantin Limarev )
            - https://gerrit.libreoffice.org/#/c/162978

* GSoC (Ilmari)
    + https://blog.documentfoundation.org/blog/2024/05/07/projects-selected-for-libreoffice-in-the-google-summer-of-code-2024/
    + next deadline: end of bonding period: 27th of May
    + blog post is published, seeing emails from contributors

* Commit Access
  + Jonathan Clark
    + pretty happy with the commits so far (Caolan)
    + with the condition to self-review in areas where you're confident, and not otherwise
    + also please help out with reviews for changes by others
=> go ahead (all)
AI: send welcome mail (Xisco)
AI: enable the commit bit (Cloph)

* LibreOffice Technology hackfest at Budapest (Miklos)
  + 4th & 5th June (Tue-Wed)
  + details: https://wiki.documentfoundation.org/Hackfest/Budapest2024

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 4 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 202 ok: 193 ko:   7 fail ratio: 3.47% mean_ok:  10 ( 13) median_ok:   7 (  8)
gerrit_android_arm         jobs: 204 ok: 194 ko:   6 fail ratio: 2.94% mean_ok:   9 ( 12) median_ok:   7 (  9)
gerrit_android_x86         jobs: 201 ok: 193 ko:   7 fail ratio: 3.48% mean_ok:  10 ( 13) median_ok:   7 (  9)
gerrit_android_x86_64      jobs: 204 ok: 196 ko:   5 fail ratio: 2.45% mean_ok:  10 ( 13) median_ok:   8 ( 10)
gerrit_linux_clang_dbgutil jobs: 410 ok: 353 ko:  46 fail ratio: 11.22% mean_ok:  42 ( 44) median_ok:  41 ( 42)
gerrit_linux_gcc_release   jobs: 461 ok: 394 ko:  55 fail ratio: 11.93% mean_ok:  19 ( 21) median_ok:  15 ( 16)
gerrit_mac                 jobs: 417 ok: 355 ko:  44 fail ratio: 10.55% mean_ok:  53 ( 55) median_ok:  49 ( 50)
gerrit_windows             jobs: 432 ok: 314 ko: 103 fail ratio: 23.84% mean_ok:  69 (114) median_ok:  71 ( 85)
gerrit_master_ml           jobs: 500 ok: 281 ko: 188 fail ratio: 37.60% mean_ok: 127 (127) median_ok:  99 ( 99)
gerrit_master              jobs:  61 ok:  40 ko:  17 fail ratio: 27.87% mean_ok: 100 (101) median_ok:  83 ( 83)
gerrit_master_seq          jobs: 440 ok: 241 ko: 172 fail ratio: 39.09% mean_ok: 130 (131) median_ok: 102 (102)
   + tests that failed more than twice in last seven days
      3 UITest_sw_navigator                gerrit_linux_clang_dbgutil
      4 aborted by jenkins job timeout                gerrit_windows
      4 CppunitTest_svx_unit                gerrit_linux_gcc_release
      4 JunitTest_toolkit_unoapi_1                gerrit_linux_clang_dbgutil
      5 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      5 CppunitTest_sw_ooxmlexport7                gerrit_linux_gcc_release
      5 CppunitTest_sw_rtfexport8                gerrit_linux_gcc_release
     12 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil_branch
     13 CppunitTest_sw_a11y                gerrit_windows
   + this week: we had an unexpected restart of Jenkins last Thursday (Cloph)
    + it affected a couple of builds
    + also yesterday: Jenkins disk was filled up, caused a bigger distruption
    + it's not easy to trigger builds for these
      + possibly will work this around by rebasing
    + Windows failure on Friday: failed some builds due to leftovers
    + good news: macOS clang crash seems to be fixed by a patch, thanks Noel
      + https://gerrit.libreoffice.org/c/core/+/167294
      + didn't see any failures with new enough master

* What’s cooking (Miklos)
    + A11y update (Michael W)
    + RTL/CTL/CJK update (Jonathan)
        + tdf#61444 Correct Writer text layout across formatting changes
            + https://bugs.documentfoundation.org/show_bug.cgi?id=61444
            + In-flight
        + tdf#124116 Correct Writer text shaping across formatting changes
            + https://bugs.documentfoundation.org/show_bug.cgi?id=124116
            + Fix mostly complete; investigating some justification issues
    + tdf#160984 Section-based continuous endnotes in Writer (Miklos)
    + Dev Guide updates (Ilmari)
        + API links all work now
          + finished by scripting it :-)
        + Stéphane adding newly-ported examples
        + Synchronising wiki content/code with the current state of core repo based on pointers in 'git log odk/examples'

* QA update (Xisco)
    + UNCONFIRMED: 1208 (+28)
        + enhancements: 281  (+5)
        + needsUXEval: 5 (-2)
        + haveBackTrace: 10 (+0)
        + needsDevAdvice: 47 (+0)
        + documentation:  6 (+2)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  9 (+0)


    + Most pressing bugs:
     New:

    None



    + New high severity bugs of the week:

         None


* QA stats (Stéphane)
    + Some interesting consolidated/reviewed reports:
        * (sw) Top row(s) deselected when selecting table rows beyond what is visible: https://bugs.documentfoundation.org/show_bug.cgi?id=126377
        * (sw) Furigana (ruby) character selection system undesired output: https://bugs.documentfoundation.org/show_bug.cgi?id=107184
        * (ui) Chart sidebar glitches reaches 12 duplicates: https://bugs.documentfoundation.org/show_bug.cgi?id=94322
        * (ui) tabbed UI's cog/hamburger menu opens in wrong display. 4 reports on this issue, but Windows and Linux separate for now:
            * Windows: https://bugs.documentfoundation.org/show_bug.cgi?id=132139
            * Linux: https://bugs.documentfoundation.org/show_bug.cgi?id=154592
            * Should they be merged?
              + think it's fine to keep them separate (Ilmari)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +103  -22 (-114) overall)
      many thanks to the top bug squashers:
       QA Administrators       20
       Stéphane Guillou (stragu) 18
       Heiko Tietze            10
       Mike Kaganski           10
       Olivier Hallot          6
       Buovjaga                5
       V Stuart Foote          5
       Michael Weghorn         3
       Patrick Luby (volunteer) 3
       Julien Nabet            2

    + top 10 bugs reporters:
       Eyal Rozenberg          6
       Gabor Kelemen (allotropia) 4
       Mike Kaganski           4
       Stéphane Guillou (stragu) 4
       NOYB                    3
       Regina Henschel         3
       Robert Großkopf         3
       V Stuart Foote          3
       Heiko Tietze            2
       Mihai Vasiliu           2

    + top 10 bugs fixers:
       Kaganski, Mike          7
       Heiko Tietze            6
       Olivier Hallot          5
       Patrick Luby            3
       Balazs Varga            2
       Justin Luth             2
       Nabet, Julien           2
       Stéphane Guillou        2
       Vajna, Miklos           2
       Weghorn, Michael        2

    + top 10 bugs confirmers:
       Stéphane Guillou        11
       Heiko Tietze            9
       m.a.riosv               9
       Nabet, Julien           6
       Ilmari Lauhakangas      3
       Kaganski, Mike          3
       *UNKNOWN*               2
       Dieter                  2
       Robert Großkopf         2
       Vernon, Stuart Foote    2


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Stéphane Guillou       4
        Raal                   2


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Stéphane Guillou       4
        Raal                   2


* all bugs tagged with 'regression'
   + 1236(+4) bugs open of 13341(+14) total 23(+2) high prio.

     done by:
        Stéphane Guillou       3
        Ady                    2
        m.a.riosv              2
        Kaganski, Mike         1
        Raal                   1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 15(+1)
     Calc          - 2(+0)
     Impress       - 2(+0)
     UI            - 2(+1)
     LibreOffice   - 1(+0)

   by OS:
     All           - 17(+1)
     Linux         - 4(+1)
     Mac OS X      - 0(+0)
     Windows       - 2(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 433(+1)
     Calc                     - 227(+3)
     Impress                  - 127(+0)
     Draw                     - 52(-1)
     LibreOffice              - 51(+0)
     Writer: docx filter      - 45(+0)
     Base                     - 40(+0)
     Crashes                  - 39(+1)
     UI                       - 38(+1)
     Borders                  - 35(+0)
     Writer: perf             - 34(-1)
     Writer: other filter     - 30(+0)
     Printing and PDF export  - 25(+1)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     filters and storage      - 22(+0)
     BASIC                    - 20(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 12(+0)
     Formula Editor           - 7(+0)
     framework                - 3(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux