ESC meeting minutes: 2024-03-21

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Cloph, Olivier, Heiko, Ilmari, Caolan, Michael W, Stephan, Caolan, Xisco, sockseight, Michael S, Miklos

* Completed Action Items:
    + communicate the copyright year backport decision on the gerrit to Martin (Cloph)

* Pending Action Items:
    + file easy hack to move the copyright year out of the about dialog l10n strings (Xisco)

* Release Engineering update (Cloph)
    + 7.6: 7.6.6 RC2 this week, tagged on Tue, going to tag an RC3 later
      + see that the branch had a commit that was reverted on master (Xisco)
      + should we also have that in the RC3?
        + would be reverted in 7.6.7
        + will push the reverts (also for 7.6.6) to gerrit (Xisco)
          + if conflicts are non-trivial, poke Oliver (Michael S)
    + 24.2.2 RC2 this week, probably tomorrow
    + MAR updates (Stephan)
      + 32bit one looks OK; 64bit looks problematic
      + need to check, possibly it's the wrong symlink problem (Cloph)
        + patch size was not matching

* Documentation (Olivier)
    + New Help (no news)
    + Helpcontents 2
        + Updates and fixes (G. Kelemen, ohallot)
    + Guides
        + Evaluation of CAT tools for Guides translations

    + Bugzilla Documentation statistics
        273(273) bugs open
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
           created     17(-4)     60(12)    82(11)    232(4)
         commented     27(-20)   129(24)   239(15)    898(-11)
          resolved      4(-4)     23(4)     34(4)     117(1)
    + top 10 contributors:
          Vernon, Stuart Foote made 47 changes in 1 month, and 87 changes in 1 year
          Olivier Hallot made 37 changes in 1 month, and 265 changes in 1 year
          Pierre F made 29 changes in 1 month, and 29 changes in 1 year
          Adolfo Jayme Barrientos made 21 changes in 1 month, and 24 changes in 1 year
          Heiko Tietze made 21 changes in 1 month, and 99 changes in 1 year
          Stéphane Guillou made 20 changes in 1 month, and 266 changes in 1 year
          Dione Maddern made 15 changes in 1 month, and 15 changes in 1 year
          Ilmari Lauhakangas made 14 changes in 1 month, and 92 changes in 1 year
          *UNKNOWN* made 11 changes in 1 month, and 11 changes in 1 year
          Mac made 7 changes in 1 month, and 9 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        248(248) (topicUI) bugs open, 37(37) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added      7(1)     14(0)     16(1)       26(0)
         commented     78(15)   242(16)   465(-1)    2006(-19)
           removed      0(0)      0(0)      1(0)       14(0)
          resolved      5(-1)    28(-1)    72(-5)     313(-5)
    + top 10 contributors:
          Heiko Tietze made 110 changes in 1 month, and 1184 changes in 1 year
          Stéphane Guillou made 90 changes in 1 month, and 661 changes in 1 year
          Vernon, Stuart Foote made 60 changes in 1 month, and 284 changes in 1 year
          Ady made 23 changes in 1 month, and 148 changes in 1 year
          Patrick Luby made 16 changes in 1 month, and 19 changes in 1 year
          Devansh Varshney made 14 changes in 1 month, and 14 changes in 1 year
          Ilmari Lauhakangas made 13 changes in 1 month, and 157 changes in 1 year
          m.a.riosv made 11 changes in 1 month, and 70 changes in 1 year
          Nabet, Julien made 10 changes in 1 month, and 27 changes in 1 year
          Kaganski, Mike made 9 changes in 1 month, and 98 changes in 1 year
    + [Bug 159286] Single click inside text field should select full field if
           it has the placeholder text
    + [Bug 160282] Ranges references text colors for in-cell editing of formulas
           are too dark for dark mode, causing low contrast
    + [Bug 160241] Scrollbar arrows not always visible despite Windows settings
    + [Bug 160255] Named Ranges Should Be Able to be Used in Conditional Formatting
           Dialog Box
    + [Bug 160230] MRU Recent files list entries numbered, no need to be
    + [Bug 160227] Add timer/clock to single-screen presentation

 -> * https://bugs.documentfoundation.org/show_bug.cgi?id=157591
      + context menu: "add to dictionary" -- no need to deselect word before
      + .ui just means this used to be an RSC menu in the past (Caolan)
      + the menu is a bit special as the suggested words are menu items
        + could take the recent docs sub-menu as example
      + possibly just nobody converted this to a .xml context menu

* Crash Testing (Caolan)
    + 15(+13) import failure, 1(+1) export failures
      - new since https://gerrit.libreoffice.org/c/core/+/164788
      - https://wiki.documentfoundation.org/Development/Crashtesting
    + 0 coverity issues
    + 6 ossfuzz issues
      - 2 new fuzzers, calc html import fuzzer, and (Noel G) fods to xls export fuzzer
      - 1 new calc html issue found

* Crash Reporting (Xisco)
    + 7.6.5.2    3536(+1426)
    + 24.2.0.3    12197(+1148)
    + 24.2.1.2    4121(+1876)

* Mentoring (Hossein, Michael W)
   + dev blog post: "Test improvement – More and better tests for LibreOffice"
     + https://dev.blog.documentfoundation.org/2024/03/18/test-improvement-more-and-better-tests-for-libreoffice/
          committer...   1 week     1 month     3 months    12 months
                  open      81(17)     158(22)     160(22)      160(22)
               reviews     534(152)   1670(120)   3884(118)   12246(192)
                merged     230(-25)   1199(-57)   3313(-76)   12397(-13)
             abandoned      13(-6)      73(-2)     179(0)       672(4)
           own commits     154(-17)    799(-7)    2216(-48)    9330(-45)
        review commits      70(-15)    344(-14)    910(-8)     3003(-36)
        contributor...   1 week     1 month     3 months     12 months
                  open      34(5)       75(6)       75(4)         75(4)
               reviews     722(-36)   3068(-80)   7812(-152)   29732(-96)
                merged      27(-3)     130(-9)     353(-5)      1852(-51)
             abandoned       5(2)      206(-4)     299(-3)       689(-5)
           own commits      26(-21)    162(-25)    409(-6)      1039(-30)
        review commits       0(0)        0(0)        0(0)          0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 329(329)
       total 411(411)   assigned 27(27)   open 348(348)
    + top 10 contributors:
          Pierre F made 22 patches in 1 month, and 22 patches in 1 year
          Dr. David Alan Gilbert made 18 patches in 1 month, and 41 patches in 1 year
          Stéphane Guillou made 10 patches in 1 month, and 62 patches in 1 year
          Kurt Nordback made 9 patches in 1 month, and 23 patches in 1 year
          Armin Le Grand (allotropia) made 8 patches in 1 month, and 85 patches in 1 year
          Ahmed Hamed made 6 patches in 1 month, and 6 patches in 1 year
          Rafał Dobrakowski made 4 patches in 1 month, and 9 patches in 1 year
          Weblate made 3 patches in 1 month, and 21 patches in 1 year
          Luv Sharma made 3 patches in 1 month, and 15 patches in 1 year
          Sujatro Bhadra made 3 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Vajna, Miklos made 184 review comments in 1 month, and 1080 in 1 year
          Caolán McNamara made 136 review comments in 1 month, and 1294 in 1 year
          Nabet, Julien made 124 review comments in 1 month, and 982 in 1 year
          Grandin, Noel made 102 review comments in 1 month, and 650 in 1 year
          Adolfo Jayme Barrientos made 102 review comments in 1 month, and 490 in 1 year
          Ilmari Lauhakangas made 96 review comments in 1 month, and 486 in 1 year
          Michael Stahl made 86 review comments in 1 month, and 960 in 1 year
          Thorsten Behrens made 76 review comments in 1 month, and 640 in 1 year
          Hossein made 70 review comments in 1 month, and 294 in 1 year
          Christian Lohmaier made 66 review comments in 1 month, and 362 in 1 year
    + Patches automatically abandoned:
        convert UseOnPage bit flags to struct of bools ( Tomaž Vajngerl )
            - https://gerrit.libreoffice.org/#/c/159562
        WIP: move UpdateAttr to SfxHint ( Bjoern Michaelsen )
            - https://gerrit.libreoffice.org/#/c/162037
        WIP: move UpdateAttr to SfxHint ( Bjoern Michaelsen )
            - https://gerrit.libreoffice.org/#/c/162065
        sc: use pGridWin.size() in for loops instead of hardcoded 4 ( Tomaž Vajngerl )
            - https://gerrit.libreoffice.org/#/c/162173
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          David Carter
          Ritobroto Mukherjee

* Outreachy (Ilmari)
    + Omkar's blog: https://omkaracharekar.hashnode.dev/

* GSoC (Ilmari)
    + https://summerofcode.withgoogle.com/programs/2024/organizations/libreoffice
    + https://wiki.documentfoundation.org/Development/GSoC/2024
    + April 2: application deadline
    + still looking for mentors, but it's under control

* Commit Access

* Developer Certification (Stephan/Miklos/László/Gabriel)
AI: Stephan to reach out to the discussed candidate

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 188 ok: 183 ko:   4 fail ratio: 2.13% mean_ok:  11 ( 17) median_ok:   7 ( 11)
gerrit_android_arm         jobs: 187 ok: 175 ko:   9 fail ratio: 4.81% mean_ok:  10 ( 16) median_ok:   7 (  8)
gerrit_android_x86         jobs: 189 ok: 185 ko:   3 fail ratio: 1.59% mean_ok:  11 ( 16) median_ok:   8 ( 11)
gerrit_android_x86_64      jobs: 188 ok: 178 ko:   8 fail ratio: 4.26% mean_ok:  11 ( 17) median_ok:   8 ( 11)
gerrit_linux_clang_dbgutil jobs: 383 ok: 300 ko:  76 fail ratio: 19.84% mean_ok:  38 ( 45) median_ok:  35 ( 40)
gerrit_linux_gcc_release   jobs: 421 ok: 362 ko:  47 fail ratio: 11.16% mean_ok:  18 ( 23) median_ok:  14 ( 17)
gerrit_mac                 jobs: 388 ok: 347 ko:  31 fail ratio: 7.99% mean_ok:  54 ( 55) median_ok:  48 ( 48)
gerrit_windows             jobs: 421 ok: 244 ko: 155 fail ratio: 36.82% mean_ok:  66 (174) median_ok:  61 (133)
gerrit_master_ml           jobs: 460 ok: 208 ko: 220 fail ratio: 47.83% mean_ok: 197 (203) median_ok: 145 (146)
gerrit_master              jobs:  51 ok:  20 ko:  29 fail ratio: 56.86% mean_ok: 200 (200) median_ok: 187 (187)
gerrit_master_seq          jobs: 408 ok: 188 ko: 190 fail ratio: 46.57% mean_ok: 192 (197) median_ok: 140 (140)
   + tests that failed more than twice in last seven days
      3 UITest_sw_navigator                gerrit_linux_clang_dbgutil
      4 CppunitTest_sw_ooxmlexport19                gerrit_linux_gcc_release
      7 JunitTest_sw_unoapi_3                gerrit_linux_clang_dbgutil
      7 UITest_calc_tests4                gerrit_linux_clang_dbgutil
      7 UITest_writer_tests8                gerrit_linux_clang_dbgutil
     14 CppunitTest_sw_a11y                gerrit_windows
     68 aborted by jenkins job timeout                gerrit_windows
    + we started to have a big problem with the Windows build (Cloph)
      + all 68 failed earlier yesterday or today
      + 3 affected machines
      + hard to auto-take-care-of this problem
      + once the box is rebooted, it's OK
      + so it's not a poor test? (Stephan)
        + the timeout handler kills processes, found no leftover processes (Cloph)
        + is it better after a reboot? (Stephan)
          + so far the builds are good after a reboot (Cloph)
      + default timeout was 30 mins (no output), now reduced to 20 mins
    + also a large set of small fixes (24-25) was submitted, good to go by smaller pieces (Cloph)

* What’s cooking (Miklos)
    + A11y update (Michael W)
       + gtk4: implemented initial support for text attributes
       + Accerciser: working on better Wayland support
    + 3D shapes, extruded shapes (Regina)
      + import material of extruded shapes is now done
    + SVG Filters (Xisco)

        - feMerge, feComposite, feBlend


* COOL Days 2024 (Miklos)
  + https://www.collaboraoffice.com/cool-days-2024/  8th -> 10th April
  + LibreOffice Technology hackfest as part of it

* QA update (Xisco)
    + UNCONFIRMED: 1151 (+27)
        + enhancements: 284  (+4)
        + needsUXEval: 8 (-1)
        + haveBackTrace: 10 (+0)
        + needsDevAdvice: 45 (-1)
        + documentation:  7 (+1)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  9 (+0)


    + Most pressing bugs:
     New:
         None
     Old:
     Fixed:
        + Selection invisible in a11y High Contrast modes with SKIA/Raster, Skia/Vulkan unaffected
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160036
            + Thanks to Patrick

    + New high severity bugs of the week:
        + Inserted GIF flipped vertically; previews in Gallery flipped or mangled
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160016
            + bisected to Tomaz

        + allow to "Encrypt with GPG key" on save using public keys with unknown Ownertrust
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160184
            + not marked as a regression

* Timezone change (Cloph)
  + next week: unchanged
  + Berlin time summer time after that

* QA stats (Stéphane)
    + Clarified/consolidated bugs:
        * (sd) Object's internal hyperlinks / interactions to slides are not functional when exporting presentation to PDF: https://bugs.documentfoundation.org/show_bug.cgi?id=103562
    + QA Dashboard data updated: https://stragu.shinyapps.io/lo_qa_dashboard/
    + Wiki tables (top bugs/enhancement/regression by CC/dupes) updated: https://wiki.documentfoundation.org/QA/Bugzilla/Statistics#Bugs
    + Weekly report: https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +109  +8 (-85) overall)
      many thanks to the top bug squashers:
       Stéphane Guillou (stragu) 12
       QA Administrators       10
       Mike Kaganski           6
       Julien Nabet            5
       Heiko Tietze            4
       V Stuart Foote          4
       Adolfo Jayme Barrientos 3
       Alain Romedenne         3
       Buovjaga                3
       Justin L                3

    + top 10 bugs reporters:
       Stéphane Guillou (stragu) 3
       contact                 3
       peter josvai            3
       steve                   3
       Cor Nouws               2
       Csábi Frigyes           2
       Dan Dascalescu          2
       Daniel Dubourg          2
       Eric Champy             2
       Eyal Rozenberg          2

    + top 10 bugs fixers:
       Kaganski, Mike          4
       Alain Romedenne         3
       Justin Luth             3
       Nabet, Julien           3
       Adolfo Jayme Barrientos 2
       Adriano M               1
       Andreas Heinisch        1
       Aung, Khant Oo          1
       Heiko Tietze            1
       Köse, Gülşah            1

    + top 10 bugs confirmers:
       Stéphane Guillou        21
       Heiko Tietze            6
       *UNKNOWN*               5
       Vernon, Stuart Foote    5
       Nabet, Julien           3
       Raal                    3
       m.a.riosv               3
                               1
       Adolfo Jayme Barrientos 1
       Ady                     1


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Aron Budea             2
        Raal                   2
        Stéphane Guillou       2
        Michael Warner         1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Raal                   2
        Stéphane Guillou       2
        Aron Budea             1
        Michael Warner         1


* all bugs tagged with 'regression'
   + 1247(+2) bugs open of 13256(+10) total 20(+0) high prio.

     done by:
        Raal                   2
        Stéphane Guillou       2
        Michael Warner         1
        Kaganski, Mike         1
        Robert Großkopf        1
        Xisco Fauli            1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 13(-1)
     Calc          - 2(+1)
     LibreOffice   - 2(+0)
     Impress       - 1(+0)
     UI            - 1(+0)

   by OS:
     All           - 14(+0)
     Linux         - 5(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 444(+1)
     Calc                     - 226(+1)
     Impress                  - 126(-1)
     LibreOffice              - 54(-1)
     Draw                     - 52(+0)
     Crashes                  - 46(+0)
     Writer: docx filter      - 45(+0)
     Base                     - 39(+0)
     UI                       - 37(+0)
     Borders                  - 36(+0)
     Writer: perf             - 35(+0)
     Writer: other filter     - 32(+1)
     Chart                    - 24(+0)
     Printing and PDF export  - 24(-1)
     RTL                      - 24(+1)
     filters and storage      - 22(+0)
     BASIC                    - 19(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 12(+0)
     Formula Editor           - 7(+0)
     framework                - 3(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)