Re: Adding NeoOffice code to existing LibreOffice code

[Patrick Luby <guibomacdev@xxxxxxxxx>]

I was able to avoid copying any NeoOffice code for tdf#126638. The NeoOffice fix used “selector swizzling” to override -[NSWindow performKeyEquivalent:] and I wanted to avoid any swizzling. Fortunately, I was able to use one the standard NSMenuDelegate callbacks to detect the problem.

I would still like to know if there we have any standard wording in the license header when adding third-party code inline. While I didn’t need to copy any code this time, there are lots and lots of inline fixes in the NeoOffice code that, over time, I would like to copy in.

Is this something that the ESC or legal committee needs to discuss?

Patrick

> On Feb 16, 2024, at 9:35 AM, Patrick Luby <guibomacdev@xxxxxxxxx> wrote:
> 
> I would like to add some NeoOffice code to LibreOffice to fix the following macOS bug:
> 
>   https://bugs.documentfoundation.org/show_bug.cgi?id=126638
> 
> NeoOffice is now MPL v2.0 like LibreOffice so I assume that I will need to add some text in the license header of any LibreOffice files that I add NeoOffice code to.
> 
> I see that LibreOffice already has a template for the Apache code (see below) but it looks customized to specifically Apache. So my question is there a template for incorporating MPL v2.0 code that I can use?
> 
> 
>   * This file incorporates work covered by the following license notice:
>   *
>   *   Licensed to the Apache Software Foundation (ASF) under one or more
>   *   contributor license agreements. See the NOTICE file distributed
>   *   with this work for additional information regarding copyright
>   *   ownership. The ASF licenses this file to you under the Apache
>   *   License, Version 2.0 (the "License"); you may not use this file
>   *   except in compliance with the License. You may obtain a copy of
>   *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
> 
> 
> Patrick