New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
40 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1585309:  Null pointer dereferences  (REVERSE_INULL)
/svl/source/items/itemset.cxx: 339 in implCreateItemEntry(SfxItemPool &, const SfxPoolItem *, unsigned short, bool)()


________________________________________________________________________________________________________
*** CID 1585309:  Null pointer dereferences  (REVERSE_INULL)
/svl/source/items/itemset.cxx: 339 in implCreateItemEntry(SfxItemPool &, const SfxPoolItem *, unsigned short, bool)()
333             pTargetPool = pTargetPool->GetSecondaryPool();
334     
335         // if this goes wrong, an Item with invalid ID for this pool is
336         // processed. This is not allowed (and should not happen, e.g.
337         // ItemSets already have WhichRanges that are checked against
338         // their Pool)
>>>     CID 1585309:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pTargetPool" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
339         if (nullptr == pTargetPool)
340         {
341             assert(false);
342             return pSource;
343         }
344     

** CID 1585308:  Uninitialized members  (UNINIT_CTOR)
/sw/source/uibase/misc/swruler.cxx: 101 in SwCommentRuler::SwCommentRuler(SwViewShell *, vcl::Window *, SwEditWin *, SvxRulerSupportFlags, SfxBindings &, long)()


________________________________________________________________________________________________________
*** CID 1585308:  Uninitialized members  (UNINIT_CTOR)
/sw/source/uibase/misc/swruler.cxx: 101 in SwCommentRuler::SwCommentRuler(SwViewShell *, vcl::Window *, SwEditWin *, SvxRulerSupportFlags, SfxBindings &, long)()
95         maFadeTimer.SetInvokeHandler(LINK(this, SwCommentRuler, FadeHandler));
96     
97         // we have a little bit more space, as we don't draw ruler ticks
98         vcl::Font aFont(maVirDev->GetFont());
99         aFont.SetFontHeight(aFont.GetFontHeight() + 1);
100         maVirDev->SetFont(aFont);
>>>     CID 1585308:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbIsDrag" is not initialized in this constructor nor in any functions that it calls.
101     }
102     
103     SwCommentRuler::~SwCommentRuler() { disposeOnce(); }
104     
105     void SwCommentRuler::dispose()
106     {

** CID 1585307:    (OVERRUN)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2344 in chart::VSeriesPlotter::getRenderOrder() const()
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2345 in chart::VSeriesPlotter::getRenderOrder() const()


________________________________________________________________________________________________________
*** CID 1585307:    (OVERRUN)
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2344 in chart::VSeriesPlotter::getRenderOrder() const()
2338     } // unnamed
2339     
2340     sal_Int32 VSeriesPlotter::getRenderOrder() const
2341     {
2342         OUString aChartType = m_xChartTypeModel->getChartType();
2343         for (size_t n = 0; n < sizeof(pairList); ++n) {
>>>     CID 1585307:    (OVERRUN)
>>>     Overrunning array "chart::<unnamed>::pairList" of 10 16-byte elements at element index 159 (byte offset 2559) using index "n" (which evaluates to 159).
2344             if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
2345                 return pairList[n].renderOrder;
2346             }
2347         }
2348         SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");
2349         return 0;
/chart2/source/view/charttypes/VSeriesPlotter.cxx: 2345 in chart::VSeriesPlotter::getRenderOrder() const()
2339     
2340     sal_Int32 VSeriesPlotter::getRenderOrder() const
2341     {
2342         OUString aChartType = m_xChartTypeModel->getChartType();
2343         for (size_t n = 0; n < sizeof(pairList); ++n) {
2344             if (aChartType.equalsIgnoreAsciiCase(pairList[n].chartName)) {
>>>     CID 1585307:    (OVERRUN)
>>>     Overrunning array "chart::<unnamed>::pairList" of 10 16-byte elements at element index 159 (byte offset 2559) using index "n" (which evaluates to 159).
2345                 return pairList[n].renderOrder;
2346             }
2347         }
2348         SAL_WARN("chart2", "Unsupported chart type in getRenderOrder()");
2349         return 0;
2350     }

** CID 1585306:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/cctrl/tbzoomsliderctrl.cxx: 228 in ScZoomSlider::ScZoomSlider(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider>, unsigned short)()


________________________________________________________________________________________________________
*** CID 1585306:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/cctrl/tbzoomsliderctrl.cxx: 228 in ScZoomSlider::ScZoomSlider(com::sun::star::uno::Reference<com::sun::star::frame::XDispatchProvider>, unsigned short)()
222           mbOmitPaint( false ),
223           m_xDispatchProvider(std::move(xDispatchProvider))
224     {
225         maSliderButton      = Image(StockImage::Yes, RID_SVXBMP_SLIDERBUTTON);
226         maIncreaseButton    = Image(StockImage::Yes, RID_SVXBMP_SLIDERINCREASE);
227         maDecreaseButton    = Image(StockImage::Yes, RID_SVXBMP_SLIDERDECREASE);
>>>     CID 1585306:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mnSliderLength" is not initialized in this constructor nor in any functions that it calls.
228     }
229     
230     
231     bool ScZoomSlider::MouseButtonDown( const MouseEvent& rMEvt )
232     {
233         Size aSliderWindowSize = GetOutputSizePixel();


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3D2Ok__OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJix2VnYPYEN6sMsctdZL2vVB6X-2F5v4qg8afgUhFw-2Fs2JprdFTKUHM6G8vPt2XfNLzoY-2BWww3TWmQcoV0KXbDykX-2BQrf0XkbUFUwc94mBfRwL7Lcv-2B1DMCTHxQY-2B0i-2B83bBw-2BcxQG6PWR-2Bt8Hx-2B9j4gA7RaNJzDYNcwTmjLO0S6l4o-3D