New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1538889:  Memory - illegal accesses  (RETURN_LOCAL)


________________________________________________________________________________________________________
*** CID 1538889:  Memory - illegal accesses  (RETURN_LOCAL)
/sw/source/core/docnode/ndtbl.cxx: 1923 in SwDoc::DelTable(SwTableNode *)()
1917     
1918     void SwDoc::DelTable(SwTableNode *const pTableNd)
1919     {
1920         {
1921             // tdf#156267 remove DdeBookmarks before deleting nodes
1922             SwDataChanged aTmp(SwPaM(*pTableNd, *pTableNd->EndOfSectionNode()));
>>>     CID 1538889:  Memory - illegal accesses  (RETURN_LOCAL)
>>>     In "aTmp.~SwDataChanged()", using "aTmp.m_pPam", which points to an out-of-scope temporary variable of type "SwPaM".
1923         }
1924     
1925         bool bNewTextNd = false;
1926         // Is it alone in a FlyFrame?
1927         SwNodeIndex aIdx( *pTableNd, -1 );
1928         const SwStartNode* pSttNd = aIdx.GetNode().GetStartNode();

** CID 1538888:  Integer handling issues  (NEGATIVE_RETURNS)


________________________________________________________________________________________________________
*** CID 1538888:  Integer handling issues  (NEGATIVE_RETURNS)
/filter/source/pdf/pdfexport.cxx: 1268 in PDFExport::ImplWriteWatermark(vcl::PDFWriter &, const Size &)()
1262         pDev->Pop();
1263     
1264         rWriter.Push();
1265         // tdf#152235 tag around the reference to the XObject on the page
1266         sal_Int32 const id = rWriter.EnsureStructureElement();
1267         rWriter.InitStructureElement(id, vcl::PDFWriter::NonStructElement, ::std::u16string_view());
>>>     CID 1538888:  Integer handling issues  (NEGATIVE_RETURNS)
>>>     "id" is passed to a parameter that cannot be negative.
1268         rWriter.BeginStructureElement(id);
1269         rWriter.SetStructureAttribute(vcl::PDFWriter::Type, vcl::PDFWriter::Pagination);
1270         rWriter.SetStructureAttribute(vcl::PDFWriter::Subtype, vcl::PDFWriter::Watermark);
1271         // HACK: this should produce *nothing* itself but is necessary to output
1272         // the Artifact tag here, not inside the XObject
1273         rWriter.DrawPolyLine({});

** CID 1538887:  Integer handling issues  (NEGATIVE_RETURNS)


________________________________________________________________________________________________________
*** CID 1538887:  Integer handling issues  (NEGATIVE_RETURNS)
/filter/source/pdf/pdfexport.cxx: 1366 in PDFExport::ImplWriteTiledWatermark(vcl::PDFWriter &, const Size &)()
1360         pDev->Pop();
1361     
1362         rWriter.Push();
1363         // tdf#152235 tag around the reference to the XObject on the page
1364         sal_Int32 const id = rWriter.EnsureStructureElement();
1365         rWriter.InitStructureElement(id, vcl::PDFWriter::NonStructElement, ::std::u16string_view());
>>>     CID 1538887:  Integer handling issues  (NEGATIVE_RETURNS)
>>>     "id" is passed to a parameter that cannot be negative.
1366         rWriter.BeginStructureElement(id);
1367         rWriter.SetStructureAttribute(vcl::PDFWriter::Type, vcl::PDFWriter::Pagination);
1368         rWriter.SetStructureAttribute(vcl::PDFWriter::Subtype, vcl::PDFWriter::Watermark);
1369         // HACK: this should produce *nothing* itself but is necessary to output
1370         // the Artifact tag here, not inside the XObject
1371         rWriter.DrawPolyLine({});


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DTGxv_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiwmckhO2Qmj9WZkDG4FMeFYT121Ib676N8AVSloXHZJ4N4LTRwW6S0aFKxfhPXauD0Bl2rEwnaoRVudYzgBV2gEo-2FEktt51Pmy4-2FaSNSO1w9-2B7qzuZoOzF4hP6h-2FHxj2u2Hge3vFoRcVbiI3s3Nga8XUaSOZw2HSGRqZ2P0v4xZ4-3D