New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1537992:    (DEADCODE)
/tools/source/misc/json_writer.cxx: 150 in tools::writeEscapedSequence(unsigned int, char *&)()
/tools/source/misc/json_writer.cxx: 152 in tools::writeEscapedSequence(unsigned int, char *&)()
/tools/source/misc/json_writer.cxx: 153 in tools::writeEscapedSequence(unsigned int, char *&)()
/tools/source/misc/json_writer.cxx: 151 in tools::writeEscapedSequence(unsigned int, char *&)()
/tools/source/misc/json_writer.cxx: 149 in tools::writeEscapedSequence(unsigned int, char *&)()


________________________________________________________________________________________________________
*** CID 1537992:    (DEADCODE)
/tools/source/misc/json_writer.cxx: 150 in tools::writeEscapedSequence(unsigned int, char *&)()
144             return true;
145         }
146     
147         switch (ch)
148         {
149             case '\b':
>>>     CID 1537992:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 9U:".
150             case '\t':
151             case '\n':
152             case '\f':
153             case '\r':
154             case '"':
155             case '/':
/tools/source/misc/json_writer.cxx: 152 in tools::writeEscapedSequence(unsigned int, char *&)()
146     
147         switch (ch)
148         {
149             case '\b':
150             case '\t':
151             case '\n':
>>>     CID 1537992:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 12U:".
152             case '\f':
153             case '\r':
154             case '"':
155             case '/':
156             case '\\':
157                 *pos++ = '\\';
/tools/source/misc/json_writer.cxx: 153 in tools::writeEscapedSequence(unsigned int, char *&)()
147         switch (ch)
148         {
149             case '\b':
150             case '\t':
151             case '\n':
152             case '\f':
>>>     CID 1537992:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 13U:".
153             case '\r':
154             case '"':
155             case '/':
156             case '\\':
157                 *pos++ = '\\';
158                 *pos++ = getEscapementChar(ch);
/tools/source/misc/json_writer.cxx: 151 in tools::writeEscapedSequence(unsigned int, char *&)()
145         }
146     
147         switch (ch)
148         {
149             case '\b':
150             case '\t':
>>>     CID 1537992:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 10U:".
151             case '\n':
152             case '\f':
153             case '\r':
154             case '"':
155             case '/':
156             case '\\':
/tools/source/misc/json_writer.cxx: 149 in tools::writeEscapedSequence(unsigned int, char *&)()
143                 pos += written;
144             return true;
145         }
146     
147         switch (ch)
148         {
>>>     CID 1537992:    (DEADCODE)
>>>     Execution cannot reach this statement: "case 8U:".
149             case '\b':
150             case '\t':
151             case '\n':
152             case '\f':
153             case '\r':
154             case '"':

** CID 1537991:  Error handling issues  (CHECKED_RETURN)
/cppuhelper/source/paths.cxx: 41 in <unnamed>::get_this_libpath()::[lambda() (instance 1)]::operator ()() const()


________________________________________________________________________________________________________
*** CID 1537991:  Error handling issues  (CHECKED_RETURN)
/cppuhelper/source/paths.cxx: 41 in <unnamed>::get_this_libpath()::[lambda() (instance 1)]::operator ()() const()
35     namespace {
36     
37     #if !(defined ANDROID || defined EMSCRIPTEN)
38     OUString get_this_libpath() {
39         static OUString s_uri = []() {
40             OUString uri;
>>>     CID 1537991:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "getUrlFromAddress" without checking return value (as is done elsewhere 4 out of 5 times).
41             osl::Module::getUrlFromAddress(reinterpret_cast<oslGenericFunction>(get_this_libpath), uri);
42             sal_Int32 i = uri.lastIndexOf('/');
43             if (i == -1)
44             {
45                 throw css::uno::DeploymentException("URI " + uri + " is expected to contain a slash");
46             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DFCrM_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJifFJNR51DzR8kGabU56P43a2fpmOCt2JuvKUPd1rZDwEsPxhG9SIlBBgUOghhRm-2F7-2FKoGqyWwK1vdyB-2Fx7OzjkQupHZPuIu7HCrEqYF0OsR05oAqIowsdchwKQhOFnV8rzIE6RjqX7jBnQ0MPd-2F1LUSw8YFJaZfWu2XWK-2FV54O9A-3D