On 27/04/2023 07.19, Lionel Élie Mamane wrote:
I'm reviewing https://gerrit.libreoffice.org/150546 by Nirnay. It adds a .ui file, and a "make" outputs warning like WARNING: 'GtkLabel' 'browselabel' does not specify what it labels within 'GtkFrame' 'frame1' The other preexisting .ui files also generate a bunch of them, but they are silenced in a .suppr file... What is our policy on this? Should/can Nirnay just silence them, too, by adding them to the .suppr file? I guess not. Please tell Nirnay what he should do in respect of this; I'd rather not commit as is with the warning (nor simply suppressing them) unless a UI/accessibility knowledgeable persons signs off on it (the rest of the change is nearly ready to merge, and should be completely ready within an hour so.)
For the record: Solved now thanks to the input from Samuel Thibault in the Gerrit change ( https://gerrit.libreoffice.org/c/core/+/150546 )
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
