Re: sc: test failure depending on order of execution

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

Hi Xisco,

On Thu, Mar 02, 2023 at 09:31:24AM +0100, Xisco Fauli <xiscofauli@xxxxxxxxxxxxxxx> wrote:
> Yes, you were right. There is a static counter that increments the chart
> export file names so it failed to find 'xl/charts/chart1.xml' because it was
> exported as 'xl/charts/chart2.xml'
> 
> Markus already added a mechanism to workaround this to the tests in chart2/
> in 5f7861e6ce212f47420533aed302fa4b5510557d "fix chart export tests
> correctly".
> 
> https://gerrit.libreoffice.org/c/core/+/148065 should fix it in the general
> case.

Hmm, it feels like this is an improvement, but the root cause is why we
have a static counter for charts in the first place. Do you know where
is that counter?

At least resetting that counter similar to how it's done in oox/
DrawingML::ResetMlCounters() would be good, and then you don't need
tricks on the testing side.

Regards,

Miklos