ESC meeting minutes: 2023-02-09

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Michael W, Michael S, Cloph, Xisco, Ilmari, Heiko, Stephan, Hossein, Miklos, Gabriel, Caolán, Eike, Kendy, Thorsten

* Completed Action Items:

* Pending Action Items:
    + install newer NDK on Jenkins to be able to build https://gerrit.libreoffice.org/c/core/+/146118 (Cloph)
    + deploy https://gerrit.libreoffice.org/c/lode/+/143788  "Extend kill-wrapper to also run on macOS" on the Jenkins slaves (Cloph)

* Release Engineering update (Cloph)
    + 7.5 status: 7.5.1 rc1 was tagged earlier today
      + 7.5.1 rc2 in 2 weeks
    + 7.4 status: 7.4.6 rc1 in 1 week

* Documentation (Olivier)
    + Missing Olivier
    + Bugzilla Documentation statistics
        260(260) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     5(-6)    40(-4)     95(-8)     300(-2)
         commented     9(-9)    69(-7)    286(-20)   1011(-33)
          resolved     1(-2)    13(-2)     42(-6)     180(-2)
    + top 10 contributors:
          Stéphane Guillou made 58 changes in 1 month, and 124 changes in 1 year
          Seth Chaiklin made 29 changes in 1 month, and 340 changes in 1 year
          Olivier Hallot made 19 changes in 1 month, and 387 changes in 1 year
          Heiko Tietze made 13 changes in 1 month, and 98 changes in 1 year
          Ilmari Lauhakangas made 12 changes in 1 month, and 92 changes in 1 year
          Rafael Lima made 11 changes in 1 month, and 122 changes in 1 year
          Roman Kuznetsov made 10 changes in 1 month, and 63 changes in 1 year
          Kaganski, Mike made 9 changes in 1 month, and 117 changes in 1 year
          Vernon, Stuart Foote made 7 changes in 1 month, and 23 changes in 1 year
          Adolfo Jayme Barrientos made 6 changes in 1 month, and 43 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        278(278) (topicUI) bugs open, 72(72) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added      7(-2)    18(3)     26(3)       60(0)
         commented     85(30)   267(33)   566(16)    2211(29)
           removed      1(1)      1(1)      6(-1)      32(0)
          resolved     10(5)     35(1)     79(-3)     292(-1)
    + top 10 contributors:
          Heiko Tietze made 183 changes in 1 month, and 1457 changes in 1 year
          Ilmari Lauhakangas made 53 changes in 1 month, and 209 changes in 1 year
          Stéphane Guillou made 53 changes in 1 month, and 143 changes in 1 year
          Vernon, Stuart Foote made 52 changes in 1 month, and 188 changes in 1 year
          Dieter made 34 changes in 1 month, and 220 changes in 1 year
          Rafael Lima made 29 changes in 1 month, and 226 changes in 1 year
          Eyal Rozenberg made 26 changes in 1 month, and 245 changes in 1 year
          Kaganski, Mike made 20 changes in 1 month, and 139 changes in 1 year
          Seth Chaiklin made 17 changes in 1 month, and 180 changes in 1 year
          ady made 13 changes in 1 month, and 13 changes in 1 year
    + [Bug 153474] Add a property to control text's breaks as it exists in
           graphical terminal emulator
    + [Bug 89841] [Calc] Autofilter - weak indication that autofilter was set
 -> + [Bug 153396] LibreOffice Writer: Bibliography reference: Link to bibliography
           entry, not associated URL address
      + will give it a go, the patch has to be still reviewed (Heiko)
    + [Bug 153106] Revert commit of Bug 91415 - Scale Calc's comment indicator
           with zoom level (please, do not)
    + [Bug 153344] The size of icons in the status bar should be increased to at least
           16px and the height of the status bar adjusted to allow this.
 -> + [Bug 153334] Support/default to a non-white background in Dark Mode
      + suggest: cherry-pick for 7.5.1 without l10n, because of the high number of requests
      + no problem with the backport (Caolan), but there are new strings for l10n
        + will do the work
        + Heiko to update l10n people
    + [Bug 153321] Notebook Bar (MUFFIN) separator color inconsistent in dark mode
    + [Bug 149497] CALC Enhancement. Permit "No User Input" as a data validation
           which would then permit filter sorting
    + [Bug 153322] RFE: Add Macro Security Settings button to macro infobar


* Crash Testing (Caolan)
    + 95(-7) import failure, 4(-1) export failures
      - making a little progress, some more fixes in next run
      - under 100 failures, finally
    + 2 coverity issues
      - next run should include fixes
    + 4 ossfuzz issues, no crashes

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.3.7.2
         + (-101) 884 985 901 840 606 533 431 460 855 217 0
   + https://crashreport.libreoffice.org/stats/version/7.4.4.2
         + (-469) 725 1194 1343 832 0
   + https://crashreport.libreoffice.org/stats/version/7.4.5.1
         + (-72) 573 645 0
   + https://crashreport.libreoffice.org/stats/version/7.5.0.3
         + (+1162) 1162 0


    + 7.5.0 crashes:

    - https://crashreport.libreoffice.org/stats/signature/SalInstanceTreeView::iter_compare(weld::TreeIter%20const%20&,weld::TreeIter%20const%20&)

    - Fixed wasn't backported. Done now

    - https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*)

    - Patch reverted on 7.5 & master as in 7.4.4


* Easyhack update (Hossein)
          committer...   1 week      1 month     3 months    12 months
                  open      75(3)       137(5)      141(7)       147(6)
               reviews     262(-84)    1184(-50)   3136(-46)   11474(-170)
                merged     206(-109)   1341(-20)   3576(-66)   14520(-140)
             abandoned      10(-8)       62(-8)     175(-1)      825(-8)
           own commits     133(-97)     918(-13)   2419(-78)   10689(-132)
        review commits      20(-30)     182(-48)    730(-58)    2761(-84)
        contributor...   1 week      1 month     3 months     12 months
                  open      28(11)       48(0)       54(2)         66(2)
               reviews     638(-170)   3060(-82)   7868(-144)   31470(-314)
                merged       7(-2)       51(-14)    218(-23)      854(-16)
             abandoned       2(-13)      24(-1)     250(-3)       563(-6)
           own commits       7(-7)       68(-20)    309(-36)      923(-33)
        review commits       0(0)         0(0)        0(0)          0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 320(320)
       total 386(386)   assigned 18(18)   open 337(337)
    + top 10 contributors:
          Stéphane Guillou made 4 patches in 1 month, and 6 patches in 1 year
          Radhey Parekh made 3 patches in 1 month, and 7 patches in 1 year
          Chenxiong Qi made 3 patches in 1 month, and 8 patches in 1 year
            made 3 patches in 1 month, and 30 patches in 1 year
          Ekta Goel made 3 patches in 1 month, and 3 patches in 1 year
          Donkers, Winfried made 2 patches in 1 month, and 3 patches in 1 year
          Paris Oplopoios made 2 patches in 1 month, and 92 patches in 1 year
          Colomban Wendling made 2 patches in 1 month, and 11 patches in 1 year
          Shulhan made 2 patches in 1 month, and 2 patches in 1 year
          Fred Kruse made 2 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Michael Stahl made 138 review comments in 1 month, and 1146 in 1 year
          Vajna, Miklos made 128 review comments in 1 month, and 696 in 1 year
          Xisco Fauli made 82 review comments in 1 month, and 846 in 1 year
          Adolfo Jayme Barrientos made 80 review comments in 1 month, and 974 in 1 year
          Timar, Andras made 64 review comments in 1 month, and 252 in 1 year
          Grandin, Noel made 60 review comments in 1 month, and 466 in 1 year
          Nabet, Julien made 56 review comments in 1 month, and 764 in 1 year
          McNamara, Caolán made 50 review comments in 1 month, and 946 in 1 year
          Justin Luth made 46 review comments in 1 month, and 86 in 1 year
          Thorsten Behrens made 46 review comments in 1 month, and 624 in 1 year
    + Patches automatically abandoned:
        allow make check to pass on Mint LMDE5 ( Justin Luth )
            - https://gerrit.libreoffice.org/#/c/136410
        VBA: work around operator >>=  oddness here ( Hannah Meeks )
            - https://gerrit.libreoffice.org/#/c/140344
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Dipam Turkar
          Greg Kelesidis

* Mentoring (Hossein)
  * Problems with detecting UCRT
    * One case:
      * Configuration problem: checking for UCRT location fails
        https://bugs.documentfoundation.org/show_bug.cgi?id=153476
      * Problem was MS VsDevCmd.bat telemetry
        * Opt out with VSCMD_SKIP_SENDTELEMETRY=1
    * Sometimes VsDevCmd.bat does not set ucrt related environment variables
      * We may need a manual setting of UCRT folder
      * --with-ucrt-dir is something else
        * directory with the arch-specific MSU packages of the Windows Universal CRT
  + suggest to have one more configure flag, so some hardcoded / auto-detected path is configurable (Hossein)
    + no objections (all)

* GSoC (Ilmari)
  + Ideas are still welcome
  + https://wiki.documentfoundation.org/Development/GSoC/Ideas
  + https://wiki.documentfoundation.org/Development/GSoC/Ideas_without_a_mentor

* Commit Access
  + no proposals this week

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 18 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 121 ok: 110 ko:   6 fail ratio: 4.96% mean_ok:   9 ( 11) median_ok:   7 (  9)
gerrit_android_arm         jobs: 120 ok: 113 ko:   3 fail ratio: 2.50% mean_ok:   9 ( 11) median_ok:   7 (  8)
gerrit_android_x86         jobs: 121 ok: 111 ko:   6 fail ratio: 4.96% mean_ok:  10 ( 11) median_ok:   8 ( 10)
gerrit_android_x86_64      jobs: 121 ok: 114 ko:   3 fail ratio: 2.48% mean_ok:   9 ( 11) median_ok:   7 (  8)
gerrit_linux_clang_dbgutil jobs: 251 ok: 178 ko:  63 fail ratio: 25.10% mean_ok:  45 ( 46) median_ok:  44 ( 44)
gerrit_linux_gcc_release   jobs: 241 ok: 202 ko:  32 fail ratio: 13.28% mean_ok:  18 ( 18) median_ok:  16 ( 16)
gerrit_mac                 jobs: 247 ok: 180 ko:  51 fail ratio: 20.65% mean_ok:  40 ( 43) median_ok:  39 ( 40)
gerrit_windows             jobs: 257 ok: 181 ko:  52 fail ratio: 20.23% mean_ok:  59 ( 82) median_ok:  55 ( 56)
gerrit_master              jobs: 256 ok: 148 ko:  84 fail ratio: 32.81% mean_ok:  78 ( 78) median_ok:  56 ( 56)
   + https://dev-www.libreoffice.org/tmp/gerrit_230209.html
   + tests that failed more than twice in last seven days
      3 aborted due to not producing any output to the log                gerrit_windows
      4 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      7 aborted due to not producing any output to the log                gerrit_mac
  + this week was a silent week (Cloph)
    + not many builds, but also less failed builds
    + normal failure rate

* LibreOffice hackfest in Cambridge (Miklos)
  + as part of COOL days: 28 & 29th March 2023
  + Collabora can fund accommodation for people
  + https://www.collaboraoffice.com/cooldays/ has more info

* ESC budget & projects 2023 (Thorsten, Ilmari)
  + Budget document is ready, emailed a Nextcloud link to ESC members (Ilmari)
  + passed the voting sheet over to Thorsten
  + great to have a start with the current ranking (Thorsten)

* What’s cooking (Miklos)
  + Multi-page fly frames / floating tables (Miklos)
    + very early stage, SW_FORCE_FLY_SPLIT=1 is meant to allow experimenting
  + weblate improvements (Cloph)
    + database query times -> improve it with cursor usage, from minutes to seconds is the hope
    + better understanding of the problem now, at least

* QA update (Xisco)
    + UNCONFIRMED: 1417 (+10)
        + enhancements: 298  (+4)
        + needsUXEval: 9 (+1)
        + haveBackTrace: 7 (+1)
        + needsDevAdvice: 30 (-1)
        + documentation:  13 (+1)
        + android:  3 (+0)
        + iOS:  0 (+0)
        + Online:  11 (+0)

    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:
        + Position of cursor not saved correctly (see comment 46 for bibisect)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=140147
            + Michael S?

* QA stats (Stéphane)
    + looks business as usual (Xisco)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +156  -54 (-109) overall)
      many thanks to the top bug squashers:
       Buovjaga                12
       Gabor Kelemen (allotropia) 7
       Heiko Tietze            7
       Stéphane Guillou (stragu) 7
       Dieter                  6
       Eike Rathke             5
       QA Administrators       5
       V Stuart Foote          5
       Caolán McNamara         4
       Julien Nabet            3

    + top 10 bugs reporters:
       Mike Kaganski           4
       Robert Großkopf         4
       Buovjaga                3
       Regina Henschel         3
       Roman Kuznetsov         3
       dolezvo1                3
       jul                     3
       sdc.blanco              3
       Alistair Saywell        2
       Eyal Rozenberg          2

    + top 10 bugs fixers:
       Kelemen, Gabor          4
       McNamara, Caolán        4
       Michael Stahl           3
       Andreas Heinisch        2
       Heiko Tietze            2
       Ilmari Lauhakangas      2
       Justin Luth             2
       Vernon, Stuart Foote    2
       Adolfo Jayme Barrientos 1
       Aron Budea              1

    + top 10 bugs confirmers:
       Ilmari Lauhakangas      19
       Dieter                  17
       m.a.riosv               14
       Nabet, Julien           10
       Heiko Tietze            8
       Stéphane Guillou        8
       *UNKNOWN*               4
       خالد حسني               4
       Roman Kuznetsov         3
       Kaganski, Mike          2

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 2/54 -     3 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 2/85 -     2 %  (+0)
     4.0 : 1/82 -     1 %  (+0)
     old : 1/246 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Raal                   4
        Ilmari Lauhakangas     2
        Stéphane Guillou       2
        Aron Budea             1
        Kelemen, Gabor         1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Raal                   4
        Ilmari Lauhakangas     2
        Stéphane Guillou       2
        Aron Budea             1
        Kelemen, Gabor         1

* all bugs tagged with 'regression'
   + 1216(+0) bugs open of 12315(+9) total 10(+2) high prio.

     done by:
        Ilmari Lauhakangas     2
        خالد حسني              2
        Roman Kuznetsov        1
        Aron Budea             1
        Kelemen, Gabor         1
        m.a.riosv              1
        Stéphane Guillou       1

* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 7(+2)
     Calc          - 1(+0)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 7(+0)
     Linux         - 1(+1)
     Mac OS X      - 0(+0)
     Windows       - 2(+1)

* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 429(+0)
     Calc                     - 210(+0)
     Impress                  - 127(+0)
     Writer: docx filter      - 58(-1)
     Crashes                  - 51(+2)
     LibreOffice              - 49(+2)
     Draw                     - 44(+1)
     Base                     - 42(+0)
     UI                       - 39(-1)
     Writer: perf             - 35(+0)
     Borders                  - 32(-1)
     Writer: other filter     - 29(+0)
     Chart                    - 25(+0)
     RTL                      - 23(+0)
     Writer: doc filter       - 20(+0)
     Printing and PDF export  - 19(+0)
     BASIC                    - 18(+0)
     filters and storage      - 15(-1)
     graphics stack           - 15(+0)
     Formula Editor           - 3(+0)
     sdk                      - 2(+0)
     framework                - 1(+0)
     Linguistic               - 0(-1)