ESC meeting minutes: 2022-10-20

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Stephan, Caolan, Ilmari, Hossein, Cloph, Miklos, Tomaz, Thosten, Olivier, Michael S, Kendy, Gabriel

* Completed Action Items:
    + see if there are 3 devs with non-trivial commits at <https://github.com/freeonlineoffice/online> (Xisco)
    + Enable firebird as non-experimental for macOS app store builds (Cloph)
    https://git.libreoffice.org/core/+/master/dbaccess/source/ui/dlg/generalpage.cxx#158
    -> moved tracking to bugzilla: tdf#151073
    + provide specific list of steps for Xisco wrt what broke in the screenshot creation code (Olivier)
    -> done in bugzilla: tdf#151646

* Pending Action Items:
    + ignore enhancement severity for the “QA update” section (Xisco)

* Release Engineering update (Cloph)
    + 7.4 status: 7.4.3 rc1 in 2 weeks
    + 7.3 status: 7.3.7 rc2 in 1 week
    + 7.5 release plan: alpha soonish, expect a wiki page similar to 7.3, a year later

* Documentation (Olivier)
    + Helpcontent2
       + updated screenshots for master
       + Help page for chart data table (R. Lima)
       + Updates and fixes (R. Lima, ohallot, A. Barrientos)
    + Guides
       + Improvements in bookshelf project UX (Pedro Pinto Silva)
       + Further work for Guide export to HTML5

    + Bugzilla Documentation statistics
        239(239) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created      8(-2)   30(2)      72(3)      302(-3)
         commented     14(-1)   71(-1)    176(13)    1212(-6)
          resolved      3(-3)   14(2)      37(3)      196(0)
    + top 10 contributors:
          Rafael Lima made 47 changes in 1 month, and 227 changes in 1 year
          Olivier Hallot made 22 changes in 1 month, and 471 changes in 1 year
          Heiko Tietze made 21 changes in 1 month, and 110 changes in 1 year
          Telesto made 14 changes in 1 month, and 32 changes in 1 year
          Foote, V Stuart made 14 changes in 1 month, and 36 changes in 1 year
          Adolfo Jayme Barrientos made 10 changes in 1 month, and 32 changes in 1 year
          Srebotnjak, Martin made 8 changes in 1 month, and 12 changes in 1 year
          Kaganski, Mike made 6 changes in 1 month, and 120 changes in 1 year
          Dieter made 5 changes in 1 month, and 79 changes in 1 year
          Eyal Rozenberg made 5 changes in 1 month, and 7 changes in 1 year

* UX Update (Heiko)
    + Missing Heiko
    + Bugzilla (topicUI) statistics
        273(273) (topicUI) bugs open, 86(86) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added     19(15)    43(12)    53(14)      75(15)
         commented     94(17)   357(38)   659(30)    2331(50)
           removed      0(0)      2(1)      9(1)       34(1)
          resolved      3(-8)    29(-6)    82(0)      317(-3)
    + top 10 contributors:
          Eyal Rozenberg made 156 changes in 1 month, and 258 changes in 1 year
          Heiko Tietze made 128 changes in 1 month, and 1510 changes in 1 year
          Foote, V Stuart made 73 changes in 1 month, and 275 changes in 1 year
          Timur made 56 changes in 1 month, and 153 changes in 1 year
          Rafael Lima made 54 changes in 1 month, and 190 changes in 1 year
          Telesto made 46 changes in 1 month, and 176 changes in 1 year
          Dieter made 44 changes in 1 month, and 231 changes in 1 year
          V Stuart Foote made 38 changes in 1 month, and 38 changes in 1 year
          Roman Kuznetsov made 35 changes in 1 month, and 189 changes in 1 year
          Hossein made 14 changes in 1 month, and 60 changes in 1 year

* Crash Testing (Caolan)
    + 47(-88) import failure, 27(-82) export failures
      - some failures that suggest intermittent out of space
      - one temp file leak now fixed
        - hopefully it's the root of the "out of diskspace" problem
    + 0 coverity issues
    + 9 ossfuzz issues, 2 crashes

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.3.6.2
         + (+90) 695 605 523 391 313 139 0
   + https://crashreport.libreoffice.org/stats/version/7.4.0.3
         + (-47) 758 805 798 786 1197 1114 864 528 0
   + https://crashreport.libreoffice.org/stats/version/7.4.1.2
         + (-266) 1676 1942 1653 1202 783 0
   + https://crashreport.libreoffice.org/stats/version/7.4.2.3
         + (+650) 650 0

+ Fixed in 7.4.2.3

    - ScTable::FillAuto(short,long,short,long,unsigned __int64,FillDir,ScProgress *)

    - Thanks to Luboš Luňák

    - lcl_InnerCalcLayout

    - ??

    - SfxItemPool::SetDefaults(std::vector<SfxPoolItem *,std::allocator<SfxPoolItem *> > *)

    - Thanks to Julien Nabet


+ Regressions in 7.4 branch

    - void rtl::str::release<_rtl_uString>(_rtl_uString*)

    - SdrLayerIDSet::IsSet(o3tl::strong_int<short,SdrLayerIDTag>)

      - have a reproducer for this -> filed a bug, tdf#151654

      - last uno commands are visible in a crashreport, in the metadata tab


* Easyhack update (Hossein)
          committer...   1 week     1 month     3 months    12 months
                  open      61(-1)     122(0)      131(2)       135(-4)
               reviews     378(40)    1092(-54)   2928(-52)   11818(-50)
                merged     225(-14)   1068(-75)   3458(29)    14986(-285)
             abandoned      14(7)       56(-1)     161(0)       828(-6)
           own commits     172(8)      778(-49)   2609(39)    11585(-45)
        review commits      76(26)     219(3)      618(14)     3115(32)
        contributor...   1 week    1 month      3 months    12 months
                  open     159(-9)    245(4)       260(4)       277(10)
               reviews     712(48)   2634(-102)   7716(22)    32822(-4)
                merged      25(17)     62(1)       216(-21)    1160(242)
             abandoned       5(2)      25(1)        57(2)       364(16)
           own commits      30(8)      79(5)       201(-7)     1062(21)
        review commits       0(0)       0(0)         0(0)         0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 308(308)
       total 369(369)   assigned 16(16)   open 323(323)
    + top 10 contributors:
          Armin Le Grand (allotropia) made 8 patches in 1 month, and 16 patches in 1 year
            made 7 patches in 1 month, and 13 patches in 1 year
          Paris Oplopoios made 3 patches in 1 month, and 78 patches in 1 year
          Omkar Acharekar  made 3 patches in 1 month, and 3 patches in 1 year
          Kevin Suo made 2 patches in 1 month, and 20 patches in 1 year
          Aron Fischer made 2 patches in 1 month, and 2 patches in 1 year
          Calvince Otieno made 2 patches in 1 month, and 2 patches in 1 year
          Rachael Odetayo made 2 patches in 1 month, and 2 patches in 1 year
          Fukanchik, Sergey made 1 patches in 1 month, and 1 patches in 1 year
          Javier Salamanca made 1 patches in 1 month, and 5 patches in 1 year
    + top 10 reviewers:
          McNamara, Caolán made 116 review comments in 1 month, and 780 in 1 year
          Michael Stahl made 100 review comments in 1 month, and 1076 in 1 year
          Adolfo Jayme Barrientos made 90 review comments in 1 month, and 1044 in 1 year
          Vajngerl, Tomaž made 80 review comments in 1 month, and 386 in 1 year
          Nabet, Julien made 66 review comments in 1 month, and 766 in 1 year
          Xisco Fauli made 62 review comments in 1 month, and 892 in 1 year
          Thorsten Behrens made 54 review comments in 1 month, and 868 in 1 year
          Vajna, Miklos made 48 review comments in 1 month, and 492 in 1 year
          Grandin, Noel made 40 review comments in 1 month, and 394 in 1 year
          Hossein made 36 review comments in 1 month, and 250 in 1 year
    + Patches automatically abandoned: (1 from contributors, restored)
        tdf#146150 Use dispatch command instead of numerical ID for the UNO commands ( Vaibhav Malik ) -> Restored
            - https://gerrit.libreoffice.org/#/c/128801
        make a variant that has the same behaviour as the original ( Caolán McNamara )
            - https://gerrit.libreoffice.org/#/c/133528
        tdf#148000 Handle linebreaks on fontwork. ( Gülşah Köse )
            - https://gerrit.libreoffice.org/#/c/136819
        [WIP] tdf#147731 sw: Fix crash of stashed header/footer ( Attila Bakos )
            - https://gerrit.libreoffice.org/#/c/136959
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Bwakat Emmanuel Peter
          Omkar Acharekar
          Rachael Odetayo
          Calvince Otieno
          Hemant Kumar Singh

* Mentoring (Hossein)
  + Reviewed submissions from the contributors
  + Reviewed 2 old EasyHacks to make sure they are still relevant
  + Drafted a blog post on 2 EasyHacks related to fixing crash bugs
    + Crashes that you can fix - EasyHack
      https://dev.blog.documentfoundation.org/?p=583&preview=1&_ppp=e90f131cc4
  + Outreachy contribution period ongoing (Ilmari)
    + deadline to make applications is in 2 weeks

* Commit Access
  + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 5 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
    from:Thu Oct 13 13:50:46 2022
    master linux rel  jobs: 113 ok:  83 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master linux dbg  jobs: 101 ok:  71 ko:   6 fail ratio:  5.94 % break:   6 broken duration:10.18%
    master mac rel    jobs:  69 ok:  48 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master mac dbg    jobs:  76 ok:  45 ko:   2 fail ratio:  2.63 % break:   1 broken duration:20.63%
    master win rel    jobs:  68 ok:  44 ko:   1 fail ratio:  1.47 % break:   1 broken duration: 0.00%
    master win dbg    jobs:  74 ok:  50 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win64 dbg  jobs:  70 ok:  43 ko:   1 fail ratio:  1.43 % break:   1 broken duration: 0.00%
    master gerrit lin jobs: 375 ok: 322 ko:  41 fail ratio: 10.93% time for ok: mean:  21 median:  18
    master gerrit plg jobs: 358 ok: 253 ko:  86 fail ratio: 24.02% time for ok: mean:  44 median:  43
    master gerrit win jobs: 409 ok: 270 ko: 114 fail ratio: 27.87% time for ok: mean:  53 median:  46
    master gerrit mac jobs: 386 ok: 302 ko:  66 fail ratio: 17.10% time for ok: mean:  36 median:  31
    master android    jobs: 354 ok: 321 ko:  19 fail ratio:  5.37% time for ok: mean:  26 median:  17
    master gerrit all jobs: 391 ok: 203 ko: 156 fail ratio: 39.90% time for ok: mean:  66 median:  55
   + https://dev-www.libreoffice.org/tmp/gerrit_221020.html
   + tests that failed more than twice in last seven days
      3 CppunitTest_sw_mailmerge2                gerrit_windows
      3 CppunitTest_sw_mailmerge                gerrit_windows
      3 CppunitTest_sw_uiwriter6                gerrit_mac
      4 CppunitTest_vcl_layout                gerrit_windows
      5 CppunitTest_sw_uiwriter6                gerrit_windows
      5 CppunitTest_vcl_font                gerrit_mac
     11 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
     18 CppunitTest_sc_vba_macro_test                gerrit_windows (bot/cygwin)

   + slightly better than last week; still more failures than usual (Cloph)
     + mostly Windows problems around cygwin
   + infra call discussed to change the setup a bit
     + will experiment with a W11 VM, each build would start from a clean VM snapshot
     + to be deployed at larger scale
   + macOS ARM64 nightly builds? (Stephan)
     + we appearantly not build that at the moment
     + not intentional (Cloph)
       + fair to say it's officially supported
AI: create the Jenkins for this (Cloph)

* What’s cooking (Miklos)
    + Writer content controls, PDF export work is still in progress (Miklos)

* BoD asks whether we can re-evaluate LOOL atticisation (Stephan/Xisco)
  + criteria is "see if there are 3 devs with non-trivial commits at <https://github.com/freeonlineoffice/online>", see <https://wiki.documentfoundation.org/TDF/Policies/Attic>
  + git shortlog -s -n --since "3 months ago" --grep="collabora" --invert-grep
   244  andreasma
    13  Skyler Grey (*)
    10  Marco Marinello
     4  Julius Härtl (*)
     2  genofire (*)
     1  Bayram Çiçek (*)
     1  ChrisGlad (*)
     1  Gabriel Masei (*)
     1  Tushar (*)

     * also in COOL
  + cloned the repo, checked the # of commits (Xisco)
    + excluded Collabora emails, above is the list
    + then executed the same in collaboraonline/online.git
    + diff is: Andreas and Marco
      + don't know if that can count
  + didn't look into it in detail (Stephan)
  + did you check what are these commits about? (Kendy)
    + real fixes? or cherry-picks without keeping authorship? or renames?
    + would be good to know if they are substantial
    + didn't check, the first criteria is already not matching (Xisco)
AI: double-check Xisco's take & pass it to the board (Stephan)
=> no objections with this as a statement from the ESC (all)

* QA update (Xisco)
    + UNCONFIRMED: 1803 (+31)
        + enhancements: 297  (+7)
        + needsUXEval: 33 (+12)
        + haveBackTrace: 7 (+1)
        + needsDevAdvice: 27 (+0)
        + documentation:  10 (-1)
        + android:  3 (+0)
        + iOS:  0 (+0)
        + Online:  14 (+1)

    + Most pressing bugs:
     New:

         None

     Fixed:

    - RTL script text runs are reversed on PDF import, PDFIProcessor::mirrorString misbehaving

    - https://bugs.documentfoundation.org/show_bug.cgi?id=104597

    - was around for quite a while, thanks to Kevin Suo!

    - it was also budgeted (Thorsten, Ilmari)

AI: update the budget page (Ilmari)

    - Arabic still has follow-up problems (Hossein)

      - have shaped characters in Draw, need to unshape them

      - that is different (Xisco)

        - editing should be a follow-up ticket

AI: report it as a bug (Hossein)
              - think it's a feature request (Thorsten)
              - there are still follow-up patches in gerrit (Ilmari)
                - with input from Caolan / Khaled

    + New high severity bugs of the week:

    None


* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +160  -36 (-132) overall)
      many thanks to the top bug squashers:
       Julien Nabet            15
       V Stuart Foote          12
       QA Administrators       9
       Eike Rathke             8
       Buovjaga                6
       Caolán McNamara         6
       m.a.riosv               6
       Rafael Lima             5
       Rizal Muttaqin          5
       Andreas Heinisch        4

    + top 10 bugs reporters:
       Eyal Rozenberg          11
       Telesto                 6
       Mike Kaganski           4
       Regina Henschel         4
       Rizal Muttaqin          4
       David                   3
       NISZ LibreOffice Team   3
       Rafael Lima             3
       V Stuart Foote          3
       iqra                    3

    + top 10 bugs fixers:
       McNamara, Caolán        5
       Andreas Heinisch        4
       Rizal Muttaqin          4
       Grandin, Noel           3
       Németh, László          3
       Rafael Lima             3
                               2
       Adolfo Jayme Barrientos 2
       Aron Budea              2
       Bergmann, Stephan       2

    + top 10 bugs confirmers:
       Rafael Lima             9
       m.a.riosv               9
       Ilmari Lauhakangas      8
       Raal                    5
       Dieter                  4
                               3
       Roman Kuznetsov         3
       V Stuart Foote          3
       Faure, Jean-Baptiste    2
       Nabet, Julien           2

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/53 -     1 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 1/83 -     1 %  (+0)
     old : 1/246 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Raal                   3
        Ilmari Lauhakangas     1
        V Stuart Foote         1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Raal                   3
        Ilmari Lauhakangas     1

* all bugs tagged with 'regression'
   + 1175(-2) bugs open of 12068(+7) total 8(+0) high prio.

     done by:
        Ilmari Lauhakangas     1
        Kaganski, Mike         1
        Raal                   1
        V Stuart Foote         1

* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 5(+0)
     Calc          - 1(+0)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 7(+0)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)

* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 421(-1)
     Calc                     - 192(-5)
     Impress                  - 115(+0)
     Writer: docx filter      - 57(+0)
     Crashes                  - 52(+0)
     LibreOffice              - 44(+0)
     Draw                     - 41(+0)
     Base                     - 37(+0)
     UI                       - 37(+0)
     Writer: perf             - 36(+0)
     Borders                  - 33(+0)
     Writer: other filter     - 31(+0)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     Writer: doc filter       - 19(+0)
     BASIC                    - 18(+0)
     filters and storage      - 16(+2)
     Printing and PDF export  - 15(+0)
     graphics stack           - 13(+0)
     Formula Editor           - 3(+0)
     framework                - 2(+0)
     sdk                      - 2(+1)
     Linguistic               - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux